Skip to content

Code Quality: Update localization to use centralized Strings class #16932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 16, 2025
Merged

Code Quality: Update localization to use centralized Strings class #16932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d00211c
Update localization to use centralized Strings class
mrashutoshnigam Mar 2, 2025
be62356
Merge branch 'files-community:main' into main
mrashutoshnigam Mar 11, 2025
94bfb3e
Merge branch 'main' of https://github.com/mrashutoshnigam/Files
mrashutoshnigam Mar 11, 2025
9ee0f29
Update localization strings in action classes
mrashutoshnigam Mar 15, 2025
5fad257
Update localization strings in action classes
mrashutoshnigam Mar 15, 2025
f8eb959
Update localization strings in SortAction.cs
mrashutoshnigam Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Content/PlayAllAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ internal sealed partial class PlayAllAction : ObservableObject, IAction
private readonly IContentPageContext context;

public string Label
=> "PlayAll".GetLocalizedResource();
=> Strings.PlayAll.GetLocalizedResource();

public string Description
=> "PlayAllDescription".GetLocalizedResource();
=> Strings.PlayAllDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new("\uE768");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Content/RefreshItemsAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class RefreshItemsAction : ObservableObject, IAction
private readonly IContentPageContext context;

public string Label
=> "Refresh".GetLocalizedResource();
=> Strings.Refresh.GetLocalizedResource();

public string Description
=> "RefreshItemsDescription".GetLocalizedResource();
=> Strings.RefreshItemsDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new("\uE72C");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Content/Share/ShareItemAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ internal sealed partial class ShareItemAction : ObservableObject, IAction
private readonly IContentPageContext context;

public string Label
=> "Share".GetLocalizedResource();
=> Strings.Share.GetLocalizedResource();

public string Description
=> "ShareItemDescription".GetLocalizedResource();
=> Strings.ShareItemDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.Share");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Content/Tags/OpenAllTaggedActions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ sealed partial class OpenAllTaggedActions: ObservableObject, IAction
private readonly ITagsContext _tagsContext;

public string Label
=> "OpenAllTaggedItems".GetLocalizedResource();
=> Strings.OpenAllTaggedItems.GetLocalizedResource();

public string Description
=> "OpenAllTaggedItemsDescription".GetLocalizedResource();
=> Strings.OpenAllTaggedItemsDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new("\uE71D");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Display/GroupAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ protected override GroupOption GroupOption
=> GroupOption.None;

public override string Label
=> "None".GetLocalizedResource();
=> Strings.None.GetLocalizedResource();

public override string Description
=> "GroupByNoneDescription".GetLocalizedResource();
=> Strings.GroupByNoneDescription.GetLocalizedResource();
}

internal sealed partial class GroupByNameAction : GroupByAction
Expand Down
52 changes: 26 additions & 26 deletions src/Files.App/Actions/Display/SortAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ protected override SortOption SortOption
=> SortOption.Name;

public override string Label
=> "Name".GetLocalizedResource();
=> Strings.Name.GetLocalizedResource();

public override string Description
=> "SortByNameDescription".GetLocalizedResource();
=> Strings.SortByNameDescription.GetLocalizedResource();
}

internal sealed partial class SortByDateModifiedAction : SortByAction
Expand All @@ -21,10 +21,10 @@ protected override SortOption SortOption
=> SortOption.DateModified;

public override string Label
=> "DateModifiedLowerCase".GetLocalizedResource();
=> Strings.DateModifiedLowerCase.GetLocalizedResource();

public override string Description
=> "SortByDateModifiedDescription".GetLocalizedResource();
=> Strings.SortByDateModifiedDescription.GetLocalizedResource();
}

internal sealed partial class SortByDateCreatedAction : SortByAction
Expand All @@ -33,10 +33,10 @@ protected override SortOption SortOption
=> SortOption.DateCreated;

public override string Label
=> "DateCreated".GetLocalizedResource();
=> Strings.DateCreated.GetLocalizedResource();

public override string Description
=> "SortByDateCreatedDescription".GetLocalizedResource();
=> Strings.SortByDateCreatedDescription.GetLocalizedResource();
}

internal sealed partial class SortBySizeAction : SortByAction
Expand All @@ -45,10 +45,10 @@ protected override SortOption SortOption
=> SortOption.Size;

public override string Label
=> "Size".GetLocalizedResource();
=> Strings.Size.GetLocalizedResource();

public override string Description
=> "SortBySizeDescription".GetLocalizedResource();
=> Strings.SortBySizeDescription.GetLocalizedResource();
}

internal sealed partial class SortByTypeAction : SortByAction
Expand All @@ -57,10 +57,10 @@ protected override SortOption SortOption
=> SortOption.FileType;

public override string Label
=> "Type".GetLocalizedResource();
=> Strings.Type.GetLocalizedResource();

public override string Description
=> "SortByTypeDescription".GetLocalizedResource();
=> Strings.SortByTypeDescription.GetLocalizedResource();
}

internal sealed partial class SortBySyncStatusAction : SortByAction
Expand All @@ -69,10 +69,10 @@ protected override SortOption SortOption
=> SortOption.SyncStatus;

public override string Label
=> "SyncStatus".GetLocalizedResource();
=> Strings.SyncStatus.GetLocalizedResource();

public override string Description
=> "SortBySyncStatusDescription".GetLocalizedResource();
=> Strings.SortBySyncStatusDescription.GetLocalizedResource();

protected override bool GetIsExecutable(ContentPageTypes pageType)
=> pageType is ContentPageTypes.CloudDrive;
Expand All @@ -84,10 +84,10 @@ protected override SortOption SortOption
=> SortOption.FileTag;

public override string Label
=> "FileTags".GetLocalizedResource();
=> Strings.FileTags.GetLocalizedResource();

public override string Description
=> "SortByTagDescription".GetLocalizedResource();
=> Strings.SortByTagDescription.GetLocalizedResource();
}

internal sealed partial class SortByPathAction : SortByAction
Expand All @@ -96,10 +96,10 @@ protected override SortOption SortOption
=> SortOption.Path;

public override string Label
=> "Path".GetLocalizedResource();
=> Strings.Path.GetLocalizedResource();

public override string Description
=> "SortByPathDescription".GetLocalizedResource();
=> Strings.SortByPathDescription.GetLocalizedResource();

protected override bool GetIsExecutable(ContentPageTypes pageType)
=> pageType is ContentPageTypes.SearchResults;
Expand All @@ -111,10 +111,10 @@ protected override SortOption SortOption
=> SortOption.OriginalFolder;

public override string Label
=> "OriginalFolder".GetLocalizedResource();
=> Strings.OriginalFolder.GetLocalizedResource();

public override string Description
=> "SortByOriginalFolderDescription".GetLocalizedResource();
=> Strings.SortByOriginalFolderDescription.GetLocalizedResource();

protected override bool GetIsExecutable(ContentPageTypes pageType)
=> pageType is ContentPageTypes.RecycleBin;
Expand All @@ -126,10 +126,10 @@ protected override SortOption SortOption
=> SortOption.DateDeleted;

public override string Label
=> "DateDeleted".GetLocalizedResource();
=> Strings.DateDeleted.GetLocalizedResource();

public override string Description
=> "SortByDateDeletedDescription".GetLocalizedResource();
=> Strings.SortByDateDeletedDescription.GetLocalizedResource();

protected override bool GetIsExecutable(ContentPageTypes pageType)
=> pageType is ContentPageTypes.RecycleBin;
Expand Down Expand Up @@ -190,10 +190,10 @@ internal sealed partial class SortAscendingAction : ObservableObject, IToggleAct
private readonly IDisplayPageContext context;

public string Label
=> "Ascending".GetLocalizedResource();
=> Strings.Ascending.GetLocalizedResource();

public string Description
=> "SortAscendingDescription".GetLocalizedResource();
=> Strings.SortAscendingDescription.GetLocalizedResource();

public bool IsOn
=> context.SortDirection is SortDirection.Ascending;
Expand Down Expand Up @@ -225,10 +225,10 @@ internal sealed partial class SortDescendingAction : ObservableObject, IToggleAc
private readonly IDisplayPageContext context;

public string Label
=> "Descending".GetLocalizedResource();
=> Strings.Descending.GetLocalizedResource();

public string Description
=> "SortDescendingDescription".GetLocalizedResource();
=> Strings.SortDescendingDescription.GetLocalizedResource();

public bool IsOn
=> context.SortDirection is SortDirection.Descending;
Expand Down Expand Up @@ -260,10 +260,10 @@ internal sealed class ToggleSortDirectionAction : IAction
private readonly IDisplayPageContext context;

public string Label
=> "ToggleSortDirection".GetLocalizedResource();
=> Strings.ToggleSortDirection.GetLocalizedResource();

public string Description
=> "ToggleSortDirectionDescription".GetLocalizedResource();
=> Strings.ToggleSortDirectionDescription.GetLocalizedResource();

public ToggleSortDirectionAction()
{
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Display/SortFilesAndFoldersTogetherAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class SortFilesAndFoldersTogetherAction : ObservableObje
private readonly IDisplayPageContext context;

public string Label
=> "SortFilesAndFoldersTogether".GetLocalizedResource();
=> Strings.SortFilesAndFoldersTogether.GetLocalizedResource();

public string Description
=> "SortFilesAndFoldersTogetherDescription".GetLocalizedResource();
=> Strings.SortFilesAndFoldersTogetherDescription.GetLocalizedResource();

public bool IsOn
=> context.SortDirectoriesAlongsideFiles;
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Display/SortFilesFirstAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class SortFilesFirstAction : ObservableObject, IToggleAc
private readonly IDisplayPageContext context;

public string Label
=> "SortFilesFirst".GetLocalizedResource();
=> Strings.SortFilesFirst.GetLocalizedResource();

public string Description
=> "SortFilesFirstDescription".GetLocalizedResource();
=> Strings.SortFilesFirstDescription.GetLocalizedResource();

public bool IsOn
=> context.SortFilesFirst && !context.SortDirectoriesAlongsideFiles;
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Display/SortFoldersFirstAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class SortFoldersFirstAction : ObservableObject, IToggle
private readonly IDisplayPageContext context;

public string Label
=> "SortFoldersFirst".GetLocalizedResource();
=> Strings.SortFoldersFirst.GetLocalizedResource();

public string Description
=> "SortFoldersFirstDescription".GetLocalizedResource();
=> Strings.SortFoldersFirstDescription.GetLocalizedResource();

public bool IsOn
=> !context.SortFilesFirst && !context.SortDirectoriesAlongsideFiles;
Expand Down
Loading