Skip to content

Code Quality: Update localization to use centralized Strings class 09 #16957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 19, 2025
Merged

Code Quality: Update localization to use centralized Strings class 09 #16957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d00211c
Update localization to use centralized Strings class
mrashutoshnigam Mar 2, 2025
be62356
Merge branch 'files-community:main' into main
mrashutoshnigam Mar 11, 2025
94bfb3e
Merge branch 'main' of https://github.com/mrashutoshnigam/Files
mrashutoshnigam Mar 11, 2025
9ee0f29
Update localization strings in action classes
mrashutoshnigam Mar 15, 2025
40d72db
Merge branch 'main' of https://github.com/mrashutoshnigam/Files
mrashutoshnigam Mar 19, 2025
73b4977
Update localization for Git action classes
mrashutoshnigam Mar 19, 2025
178c45d
Refactor localization in sidebar action classes
mrashutoshnigam Mar 19, 2025
15c7bc1
Update localization in Pin and Unpin actions
mrashutoshnigam Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Git/GitFetchAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class GitFetchAction : ObservableObject, IAction
private readonly IContentPageContext _context;

public string Label
=> "GitFetch".GetLocalizedResource();
=> Strings.GitFetch.GetLocalizedResource();

public string Description
=> "GitFetchDescription".GetLocalizedResource();
=> Strings.GitFetchDescription.GetLocalizedResource();

public bool IsExecutable
=> _context.CanExecuteGitAction;
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Git/GitInitAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ sealed partial class GitInitAction : ObservableObject, IAction
private readonly IContentPageContext _context;

public string Label
=> "InitRepo".GetLocalizedResource();
=> Strings.InitRepo.GetLocalizedResource();

public string Description
=> "InitRepoDescription".GetLocalizedResource();
=> Strings.InitRepoDescription.GetLocalizedResource();

public bool IsExecutable =>
_context.Folder is not null &&
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Git/GitPullAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal sealed partial class GitPullAction : ObservableObject, IAction
private readonly IContentPageContext _context;

public string Label
=> "GitPull".GetLocalizedResource();
=> Strings.GitPull.GetLocalizedResource();

public string Description
=> "GitPullDescription".GetLocalizedResource();
=> Strings.GitPullDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new("\uE74B");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Git/GitPushAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ internal sealed partial class GitPushAction : ObservableObject, IAction
{
private readonly IContentPageContext _context;

public string Label { get; } = "Push".GetLocalizedResource();
public string Label { get; } = Strings.Push.GetLocalizedResource();

public string Description { get; } = "GitPushDescription".GetLocalizedResource();
public string Description { get; } = Strings.GitPushDescription.GetLocalizedResource();

public RichGlyph Glyph { get; } = new("\uE74A");

Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Git/GitSyncAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ internal sealed partial class GitSyncAction : ObservableObject, IAction
{
private readonly IContentPageContext _context;

public string Label { get; } = "GitSync".GetLocalizedResource();
public string Label { get; } = Strings.GitSync.GetLocalizedResource();

public string Description { get; } = "GitSyncDescription".GetLocalizedResource();
public string Description { get; } = Strings.GitSyncDescription.GetLocalizedResource();

public RichGlyph Glyph { get; } = new("\uEDAB");

Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Sidebar/PinFolderToSidebarAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ internal sealed partial class PinFolderToSidebarAction : ObservableObject, IActi
private readonly IQuickAccessService service;

public string Label
=> "PinFolderToSidebar".GetLocalizedResource();
=> Strings.PinFolderToSidebar.GetLocalizedResource();

public string Description
=> "PinFolderToSidebarDescription".GetLocalizedResource();
=> Strings.PinFolderToSidebarDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.FavoritePin");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Sidebar/UnpinFolderToSidebarAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ internal sealed partial class UnpinFolderFromSidebarAction : ObservableObject, I
private readonly IQuickAccessService service;

public string Label
=> "UnpinFolderFromSidebar".GetLocalizedResource();
=> Strings.UnpinFolderFromSidebar.GetLocalizedResource();

public string Description
=> "UnpinFolderFromSidebarDescription".GetLocalizedResource();
=> Strings.UnpinFolderFromSidebarDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.FavoritePinRemove");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Start/PinToStartAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ internal sealed class PinToStartAction : IAction
public IContentPageContext context;

public string Label
=> "PinItemToStart/Text".GetLocalizedResource();
=> Strings.PinItemToStart_Text.GetLocalizedResource();

public string Description
=> "PinToStartDescription".GetLocalizedResource();
=> Strings.PinToStartDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.FavoritePin");
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Actions/Start/UnpinFromStartAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ internal sealed class UnpinFromStartAction : IAction
public IContentPageContext context;

public string Label
=> "UnpinItemFromStart/Text".GetLocalizedResource();
=> Strings.UnpinItemFromStart_Text.GetLocalizedResource();

public string Description
=> "UnpinFromStartDescription".GetLocalizedResource();
=> Strings.UnpinFromStartDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.FavoritePinRemove");
Expand Down
Loading