Skip to content

Fix: Hide Cleanup and Format on Properties for Cloud Drives #16978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2025
Merged

Fix: Hide Cleanup and Format on Properties for Cloud Drives #16978

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c9eed8
Test
yaira2 Mar 24, 2025
3b2c05c
Update cd-store-preview.yml
yaira2 Mar 24, 2025
0ab1ef2
Hide Cleanup and Format on Properties for Cloud Drives
dongle-the-gadget Mar 24, 2025
942297b
Update .github/workflows/cd-store-preview.yml
yaira2 Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cd-store-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:
path: ${{ env.ARTIFACTS_STAGING_DIR }}

- name: Publish the packages to Microsoft Store
uses: isaacrlevin/windows-store-action@1.0
uses: files-community/windows-store-action@1.1
with:
app-id: '9NSQD9PKV3SS'
tenant-id: ${{ secrets.STORE_TENANT_ID }}
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/ViewModels/Properties/BasePropertiesPage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
var props = new DriveProperties(ViewModel, drive, AppInstance);
BaseProperties = props;

ViewModel.CleanupVisibility = props.Drive.Type != DriveType.Network;
ViewModel.FormatVisibility = !(props.Drive.Type == DriveType.Network || string.Equals(props.Drive.Path, $@"{Constants.UserEnvironmentPaths.SystemDrivePath}\", StringComparison.OrdinalIgnoreCase));
ViewModel.CleanupVisibility = props.Drive.Type != DriveType.Network && props.Drive.Type != DriveType.CloudDrive;
ViewModel.FormatVisibility = !(props.Drive.Type == DriveType.Network || props.Drive.Type == DriveType.CloudDrive || string.Equals(props.Drive.Path, $@"{Constants.UserEnvironmentPaths.SystemDrivePath}\", StringComparison.OrdinalIgnoreCase));
ViewModel.CleanupDriveCommand = new AsyncRelayCommand(() => StorageSenseHelper.OpenStorageSenseAsync(props.Drive.Path));
ViewModel.FormatDriveCommand = new RelayCommand(async () =>
{
Expand Down
Loading