Skip to content

Fix: Fixed an issue where name sorting was case sensitive #17029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Fix: Fixed an issue where name sorting was case sensitive #17029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Files.App/Helpers/NaturalStringComparer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public sealed class NaturalStringComparer
{
public static IComparer<object> GetForProcessor()
{
return new NaturalComparer(StringComparison.CurrentCulture);
return new NaturalComparer(StringComparison.CurrentCultureIgnoreCase);
Copy link
Member

@0x5bfa 0x5bfa Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw this is instantiated every time SortingHelper.OrderFileList is called. We prob should create a static field for this (if null, for the first time, create an instance).

Copy link
Member Author

@yaira2 yaira2 Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please start an issue so we can track that?

}

/// <summary>
Expand Down
Loading