Skip to content

Code Quality: Add background to setting expanders #17067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Code Quality: Add background to setting expanders #17067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Files.App/Views/Settings/AppearancePage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@
<GridView
Padding="8"
HorizontalAlignment="Stretch"
Background="{ThemeResource CardBackgroundFillColorDefaultBrush}"
ItemTemplate="{StaticResource AppThemeResourcesItemTemplate}"
ItemsSource="{x:Bind ViewModel.AppThemeResources, Mode=OneWay}"
SelectedItem="{x:Bind ViewModel.SelectedAppThemeResources, Mode=TwoWay}" />
Expand Down
2 changes: 1 addition & 1 deletion src/Files.App/Views/Settings/DevToolsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
ItemsSource="{x:Bind ViewModel.OpenInIDEOptions.Values}"
SelectedItem="{x:Bind ViewModel.SelectedOpenInIDEOption, Mode=TwoWay}" />
<wctcontrols:SettingsExpander.ItemsHeader>
<StackPanel Orientation="Vertical">
<StackPanel Background="{ThemeResource CardBackgroundFillColorDefaultBrush}" Orientation="Vertical">
<Grid
x:Name="IDEConfigGrid"
Padding="32,12"
Expand Down
1 change: 1 addition & 0 deletions src/Files.App/Views/Settings/GeneralPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@
<Grid
Padding="8"
HorizontalAlignment="Stretch"
Background="{ThemeResource CardBackgroundFillColorDefaultBrush}"
RowSpacing="4"
Visibility="{x:Bind ViewModel.OpenASpecificPageOnStartup, Mode=OneWay}">
<Grid.RowDefinitions>
Expand Down
2 changes: 1 addition & 1 deletion src/Files.App/Views/Settings/TagsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@

<Button Command="{x:Bind ViewModel.AddTagCommand, Mode=OneWay}" Content="{helpers:ResourceString Name=NewTag}" />
<wctcontrols:SettingsExpander.ItemsHeader>
<StackPanel>
<StackPanel Background="{ThemeResource CardBackgroundFillColorDefaultBrush}">
<!-- Create new tag -->
<Grid
x:Name="AddTagGrid"
Expand Down
Loading