Skip to content

Conversation

@gave92
Copy link
Member

@gave92 gave92 commented May 18, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

@yaira2 yaira2 changed the title Fix deleting folder too big for recycle bin Fix: Fixed issue with deleting items that don't fit in Recycle Bin May 18, 2025
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 18, 2025
@yaira2 yaira2 requested a review from 0x5bfa May 18, 2025 21:38
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this block was added here and if removing it fixes this, LGTM code wise.

@yaira2 yaira2 merged commit 8fffbb4 into files-community:main May 19, 2025
6 checks passed
@yaira2 yaira2 changed the title Fix: Fixed issue with deleting items that don't fit in Recycle Bin Fix: Fixed issue with deleting items that don't fit in Recycle Bin May 19, 2025
@yaira2
Copy link
Member

yaira2 commented May 19, 2025

@hishitetsu fyi

@gave92 gave92 deleted the issue_8358 branch May 19, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Display prompt when trying to delete folder that's too big for recycle bin

3 participants