Skip to content

Code Quality: Refactored command titles and descritption for clarity and consistency #17146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Code Quality: Refactored command titles and descritption for clarity and consistency #17146

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c59a6a2
Update Resources.resw
Lukiluc29 May 20, 2025
27158c0
Changes of small details
Lukiluc29 May 20, 2025
f69d8ae
Same
Lukiluc29 May 20, 2025
8b6ddda
Add string
Lukiluc29 May 20, 2025
6c84a29
Strings
Lukiluc29 May 20, 2025
b18338f
Copilot suggestion
Lukiluc29 May 21, 2025
6815ede
Correction of a micro error
Lukiluc29 May 21, 2025
e98c33f
First changes
Lukiluc29 May 25, 2025
074ceb8
Suggestions
Lukiluc29 May 29, 2025
ea5921d
Other requested changes
Lukiluc29 May 29, 2025
73ed7aa
Small changes
Lukiluc29 Jun 6, 2025
15e6634
Error when changing
Lukiluc29 Jun 6, 2025
1561f94
More changes...
Lukiluc29 Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Files.App/Strings/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2499,7 +2499,7 @@
<value>Clear selected items</value>
</data>
<data name="ToggleSelectDescription" xml:space="preserve">
<value>Invert selection of items</value>
<value>Change selection of the focused item</value>
</data>
<data name="ShareItemDescription" xml:space="preserve">
<value>Share selected {0, plural, one {file} other {files}} with others</value>
Expand Down Expand Up @@ -3016,7 +3016,7 @@
<value>Delete permanently</value>
</data>
<data name="DeleteItemPermanentlyDescription" xml:space="preserve">
<value>Delete selected {0, plural, one {item} other {items}} permanently without recovery</value>
<value>Delete selected {0, plural, one {item} other {items}} without recovery</value>
Copy link
Member

@yaira2 yaira2 Jun 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lukiluc29 is there any reason to avoid the word 'permanently'? It accurately describes the operation and is consistent with the terminology in File Explorer.

</data>
<data name="PlayAllDescription" xml:space="preserve">
<value>Play the selected media files</value>
Expand Down Expand Up @@ -3139,7 +3139,7 @@
<value>Properties</value>
</data>
<data name="OpenClassicProperties" xml:space="preserve">
<value>Explorer properties</value>
<value>File Explorer properties</value>
Copy link
Member

@yaira2 yaira2 Jun 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per @Jay-o-Way, this should start with 'Open'.

</data>
<data name="OpenPropertiesDescription" xml:space="preserve">
<value>Open the properties window for selected item</value>
Copy link
Member

@yaira2 yaira2 Jun 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for selected item

It's a little more complex. This action also works when no items are selected, and it also works when multiple items are selected. We can make the text contextual in the future, but it's out of scope for this PR. For now, I would keep the added 'the' but remove 'for selected item'

Expand Down