Skip to content

Code Quality: Improved Omnibar #17186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaira2 merged 3 commits into from
Jun 12, 2025
Merged

Code Quality: Improved Omnibar #17186

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
373c353
Filtered OpenCommandPalette action from Command Palette
yaira2 Jun 12, 2025
ba9419d
Scroll to top of list
yaira2 Jun 12, 2025
45143cd
Update src/Files.App.Controls/Omnibar/Omnibar.Events.cs
yaira2 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Files.App.Controls/Omnibar/Omnibar.Events.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,12 @@ private void AutoSuggestBoxSuggestionsPopup_GettingFocus(UIElement sender, Getti
args.TryCancel();
}

private void AutoSuggestBoxSuggestionsPopup_Opened(object? sender, object e)
{
if (_textBoxSuggestionsListView.Items.Count >= 0)
_textBoxSuggestionsListView.ScrollIntoView(_textBoxSuggestionsListView.Items[0]);
}

private void AutoSuggestBoxSuggestionsListView_ItemClick(object sender, ItemClickEventArgs e)
{
if (CurrentSelectedMode is null)
Expand Down
1 change: 1 addition & 0 deletions src/Files.App.Controls/Omnibar/Omnibar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ protected override void OnApplyTemplate()
_textBox.KeyDown += AutoSuggestBox_KeyDown;
_textBox.TextChanged += AutoSuggestBox_TextChanged;
_textBoxSuggestionsPopup.GettingFocus += AutoSuggestBoxSuggestionsPopup_GettingFocus;
_textBoxSuggestionsPopup.Opened += AutoSuggestBoxSuggestionsPopup_Opened;
_textBoxSuggestionsListView.ItemClick += AutoSuggestBoxSuggestionsListView_ItemClick;
_textBoxSuggestionsListView.SelectionChanged += AutoSuggestBoxSuggestionsListView_SelectionChanged;

Expand Down
3 changes: 2 additions & 1 deletion src/Files.App/ViewModels/UserControls/NavigationToolbarViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1232,7 +1232,8 @@ public void PopulateOmnibarSuggestionsForCommandPaletteMode()

foreach (var item in suggestionItems)
{
OmnibarCommandPaletteModeSuggestionItems.Add(item);
if (item.Text != Commands.OpenCommandPalette.Code.ToString())
OmnibarCommandPaletteModeSuggestionItems.Add(item);
}

if (OmnibarCommandPaletteModeSuggestionItems.Count is 0)
Expand Down
Loading