Skip to content

Code Quality: Use CommandDescription on Actions Page #17194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 15, 2025
Merged

Code Quality: Use CommandDescription on Actions Page #17194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e76bd43
Code Quality: Use CommandDescription on Actions Page
yaira2 Jun 15, 2025
d2e5c5a
Update Resources.resw
yaira2 Jun 15, 2025
c243772
Requested changes
yaira2 Jun 15, 2025
95bc21e
Updated string for detail & info pane toggle
yaira2 Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/Files.App/Strings/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,7 +1089,7 @@
<value>Toggle the info pane</value>
</data>
<data name="ToggleInfoPaneDescription" xml:space="preserve">
<value>Toggle the info pane to view the detail/preview panes</value>
<value>Toggle visibility of the detail/preview panes</value>
</data>
<data name="ToggleToolbar" xml:space="preserve">
<value>Toggle toolbar</value>
Expand Down Expand Up @@ -2421,31 +2421,31 @@
<value>Toggle whether to show sidebar</value>
</data>
<data name="CopyItemDescription" xml:space="preserve">
<value>Copy selected {0, plural, one {item} other {items}} to clipboard</value>
<value>Copy selected {0, plural, one {item} other {items}}</value>
</data>
<data name="CopyPathDescription" xml:space="preserve">
<value>Copy path of the current directory to the clipboard</value>
<value>Copy path of the current directory</value>
</data>
<data name="CopyItemPathDescription" xml:space="preserve">
<value>Copy path of selected items to the clipboard</value>
<value>Copy path of selected items</value>
</data>
<data name="CopyItemPathWithQuotesDescription" xml:space="preserve">
<value>Copy path of selected items with quotes to the clipboard</value>
<value>Copy path of selected items with quotes</value>
</data>
<data name="CopyPathWithQuotesDescription" xml:space="preserve">
<value>Copy path of the current directory with quotes to the clipboard</value>
<value>Copy path of the current directory with quotes</value>
</data>
<data name="CutItemDescription" xml:space="preserve">
<value>Cut selected {0, plural, one {item} other {items}} to clipboard</value>
<value>Cut selected {0, plural, one {item} other {items}}</value>
</data>
<data name="PasteItemDescription" xml:space="preserve">
<value>Paste clipboard items to the current folder</value>
<value>Paste items to the current folder</value>
</data>
<data name="PasteShortcutDescription" xml:space="preserve">
<value>Paste clipboard items to the current folder as shortcuts</value>
<value>Paste items to the current folder as shortcuts</value>
</data>
<data name="PasteItemToSelectionDescription" xml:space="preserve">
<value>Paste clipboard items to the selected folder</value>
<value>Paste items to the selected folder</value>
</data>
<data name="PasteToSelectedFolder" xml:space="preserve">
<value>Paste to selected folder</value>
Expand Down Expand Up @@ -2568,13 +2568,13 @@
<value>Create zip archive with selected {0, plural, one {item} other {items}}</value>
</data>
<data name="DecompressArchiveDescription" xml:space="preserve">
<value>Extract items from selected {0, plural, one {archive} other {archives}} to any folder</value>
<value>Extract selected {0, plural, one {archive} other {archives}} to any folder</value>
</data>
<data name="DecompressArchiveHereDescription" xml:space="preserve">
<value>Extract items from selected {0, plural, one {archive} other {archives}} to current folder</value>
<value>Extract selected {0, plural, one {archive} other {archives}} to the current folder</value>
</data>
<data name="DecompressArchiveToChildFolderDescription" xml:space="preserve">
<value>Extract items from selected {0, plural, one {archive} other {archives}} to new folder</value>
<value>Extract selected {0, plural, one {archive} other {archives}} to new folder</value>
</data>
<data name="RotateLeftDescription" xml:space="preserve">
<value>Rotate selected {0, plural, one {image} other {images}} to the left</value>
Expand Down Expand Up @@ -3746,7 +3746,7 @@
<value>There was an error applying this tag</value>
</data>
<data name="DecompressArchiveHereSmartDescription" xml:space="preserve">
<value>Extract items from selected {0, plural, one {archive} other {archives}} to current folder for single-item archive, or to new folder for multi-item archive</value>
<value>Extract selected {0, plural, one {archive} other {archives}} here for single-item or to new folder for multi-item</value>
</data>
<data name="ExtractHereSmart" xml:space="preserve">
<value>Extract here (Smart)</value>
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Views/Settings/ActionsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
<!-- New Command Selector -->
<uc:ComboBoxEx
x:Name="NewKeyBindingItemPickerComboBox"
DisplayMemberPath="CommandLabel"
DisplayMemberPath="CommandDescription"
DropDownClosed="NewKeyBindingItemPickerComboBox_DropDownClosed"
ItemsSource="{x:Bind ViewModel.AllActionItems, Mode=OneWay}"
PlaceholderText="{helpers:ResourceString Name=ChooseAnAction}"
Expand Down Expand Up @@ -211,7 +211,7 @@
<DataTemplate x:DataType="dataitems:ModifiableActionItem">
<UserControl PointerEntered="RootGrid_PointerEntered" PointerExited="RootGrid_PointerExited">
<Grid x:Name="RootGrid">
<controls:SettingsCard Description="{x:Bind CommandDescription}" Header="{x:Bind CommandLabel}">
<controls:SettingsCard Header="{x:Bind CommandDescription}">
<controls:SettingsCard.Content>
<Grid MinHeight="36" ColumnSpacing="12">
<Grid.ColumnDefinitions>
Expand Down
Loading