Fix: Fixed alignment of group headers #17224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
added
the
ready to merge
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses the alignment issue of group headers by updating the VerticalAlignment property across different layout pages.
- Updated VerticalAlignment in GridLayoutPage.xaml from Top to Center.
- Updated VerticalAlignment in DetailsLayoutPage.xaml from Top to Center.
- Updated VerticalAlignment in ColumnLayoutPage.xaml from Top to Center.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Files.App/Views/Layouts/GridLayoutPage.xaml | Changed header VerticalAlignment to Center for better vertical centering. |
| src/Files.App/Views/Layouts/DetailsLayoutPage.xaml | Modified header VerticalAlignment from Top to Center. |
| src/Files.App/Views/Layouts/ColumnLayoutPage.xaml | Adjusted header VerticalAlignment to Center. |
Comments suppressed due to low confidence (3)
src/Files.App/Views/Layouts/GridLayoutPage.xaml:1045
- The updated VerticalAlignment property improves header centering; please verify that the existing padding settings remain optimal with this change.
VerticalAlignment="Center"
src/Files.App/Views/Layouts/DetailsLayoutPage.xaml:1395
- Changing the header alignment to Center aligns with the intended design; confirm that the updated layout maintains visual consistency with similar elements.
VerticalAlignment="Center"
src/Files.App/Views/Layouts/ColumnLayoutPage.xaml:362
- The adjustment to Center for VerticalAlignment meets the design requirements; please ensure that the change does not adversely affect spacing or overall layout consistency.
VerticalAlignment="Center"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.