Skip to content

Code Quality: Fixed a crash that often happens when switching between Omnibar modes #17226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025
Merged

Code Quality: Fixed a crash that often happens when switching between Omnibar modes #17226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/Files.App.Controls/Omnibar/Omnibar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,15 @@ protected void ChangeMode(OmnibarMode? oldMode, OmnibarMode newMode)
if (oldMode is not null)
VisualStateManager.GoToState(oldMode, "Unfocused", true);

// Reset
foreach (var column in _modesHostGrid.ColumnDefinitions)
column.Width = GridLength.Auto;
DispatcherQueue.TryEnqueue(() =>
{
// Reset
foreach (var column in _modesHostGrid.ColumnDefinitions)
column.Width = GridLength.Auto;

// Expand the given mode
_modesHostGrid.ColumnDefinitions[index].Width = new(1, GridUnitType.Star);
// Expand the given mode
_modesHostGrid.ColumnDefinitions[index].Width = new(1, GridUnitType.Star);
});

var itemCount = Modes.Count;
var itemIndex = Modes.IndexOf(newMode);
Expand Down
Loading