Skip to content

Fix: Ensure MainWindow instance is nullified on close #17305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix: Ensure MainWindow instance is nullified on close #17305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Files.App/MainWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<!-- Copyright (c) Files Community. Licensed under the MIT License. -->
<winuiex:WindowEx
x:Class="Files.App.MainWindow"
Expand All @@ -7,4 +7,5 @@
xmlns:items="using:Files.App.Data.Items"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:winuiex="using:WinUIEx"
mc:Ignorable="d" />
mc:Ignorable="d"
Closed="MainWindow_Closed" />
6 changes: 6 additions & 0 deletions src/Files.App/MainWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
public MainWindow()
{
InitializeComponent();
Closed += MainWindow_Closed;

WindowHandle = WinUIEx.WindowExtensions.GetWindowHandle(this);
MinHeight = 316;
Expand Down Expand Up @@ -368,5 +369,10 @@
e.Handled = true;
}
}

private void MainWindow_Closed(object sender, WindowEventArgs args)

Check failure on line 373 in src/Files.App/MainWindow.xaml.cs

View workflow job for this annotation

GitHub Actions / build (Release, x64) 

The type or namespace name 'WindowEventArgs' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 373 in src/Files.App/MainWindow.xaml.cs

View workflow job for this annotation

GitHub Actions / build (Debug, arm64) 

The type or namespace name 'WindowEventArgs' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 373 in src/Files.App/MainWindow.xaml.cs

View workflow job for this annotation

GitHub Actions / build (Debug, x64) 

The type or namespace name 'WindowEventArgs' could not be found (are you missing a using directive or an assembly reference?)

Check failure on line 373 in src/Files.App/MainWindow.xaml.cs

View workflow job for this annotation

GitHub Actions / build (Release, arm64) 

The type or namespace name 'WindowEventArgs' could not be found (are you missing a using directive or an assembly reference?)
{
_Instance = null;
}
}
}
Loading