Skip to content

Conversation

@seer-by-sentry
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. The issue was automatically detected by Sentry after a crash.
  2. The fix was generated by Seer in Sentry, triggered by Yair. 👁️ Run ID: 580156
  3. Not quite right? Click here to continue debugging with Seer.
  4. The issue was that: COMException occurs when PreviewHandler.Unload() fails during disposal, unhandled in ShellPreviewViewModel.WndProc due to missing try-catch.
  5. The preview handler was re-throwing an exception after disposing of the COM site, which could cause the app to crash. This change prevents the exception from being re-thrown.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I don't think this will solve anything.

@yaira2 yaira2 closed this Jul 30, 2025
@yaira2 yaira2 deleted the seer/fix/preview-handler-exception branch July 30, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants