Code Quality: Fixed items processed string in status center #17383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string returned by `StatusCenter_ProcessedItems_Header.GetLocalizedFormatResource` is empty and does not display anything in the Status Center. - Pass the correct number of parameters to `GetLocalizedFormatResource` to get the real string instead of "". - Correct plural form for fraction. The divisor must be in accordance to the plural form, not the dividend. 8/20 items processed = Processed 8 out of 20 items.
SilverGreen93
changed the title
Member
|
Can you check how this affects the progress reporting for cloning git repos? |
Contributor
Author
All seems to work nicely. 
|
yaira2
changed the title
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string returned by
StatusCenter_ProcessedItems_Header.GetLocalizedFormatResourceis empty and does not display anything in the Status Center.GetLocalizedFormatResourceto get the real format string instead of "".8/20 items processed = Processed 8 out of 20 items.
Steps used to test these changes