Skip to content

Fix: Fixed issue where changing layouts focused the right pane #17419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 7, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Add second pane
  2. Focus on the left pane
  3. Change layouts
  4. Confirm focus remains on the left pane

@yaira2 yaira2 force-pushed the ya/FixDualPaneFocus branch 3 times, most recently from 19a66dc to c3941d9 Compare August 7, 2025 22:44
@yaira2 yaira2 force-pushed the ya/FixDualPaneFocus branch from 5617692 to ff8434b Compare August 7, 2025 23:08
@SilverGreen93
Copy link
Contributor

@yaira2 , Sorry, I am unable to verify this as I cannot reproduce the original issue. I tried changing the layout to details, list, cards etc. for both panes, but the focus remains on the affected pane, as it should. Maybe I misunderstood the steps to reproduce.

@yaira2
Copy link
Member Author

yaira2 commented Aug 10, 2025

You might have to select an item in the left pane before changing the layout.

@yaira2
Copy link
Member Author

yaira2 commented Aug 10, 2025

It's possible that this also resolves #15706.

@yaira2 yaira2 merged commit 35f7d08 into main Aug 11, 2025
9 checks passed
@yaira2 yaira2 deleted the ya/FixDualPaneFocus branch August 11, 2025 14:20
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Changing the layout of the left pane shifts focus to the right pane
2 participants