Skip to content

Conversation

@seer-by-sentry
Copy link
Contributor

@seer-by-sentry seer-by-sentry bot commented Sep 2, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Fixes FILES-APP-G0. The issue was that: FileSystemWatcher fails because redirected AppData lacks expected Windows system directory structure.

  • Prevents crashes when the AutomaticDestinations folder is missing due to AppData redirection.
  • Skips FileSystemWatcher initialization if the directory doesn't exist.
  • Checks for null PinnedItemsWatcher before accessing it.

This fix was generated by Seer in Sentry, triggered by Yair. 👁️ Run ID: 1136200

Not quite right? Click here to continue debugging with Seer.

  1. Opened Files ...
  2. ...

@yaira2 yaira2 marked this pull request as ready for review September 2, 2025 14:37
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Sep 2, 2025
@yaira2 yaira2 requested a review from 0x5bfa September 4, 2025 21:19
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, code wise. We will no longer use this path to watch the quick access so it's fine to add this sanity check anyway (I'm about to re-implement the watcher to support shell folders).

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 7, 2025
@yaira2 yaira2 merged commit b549af2 into main Sep 7, 2025
9 checks passed
@yaira2 yaira2 deleted the seer/fix-redirected-appdata branch September 7, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull requests that are ready for review ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants