Fix: Get NavigationParameter from corresponding TabBarItem #17599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a NullReferenceException that occurs when accessing TabBarItemParameter by properly retrieving the NavigationParameter from the corresponding TabBarItem instead of directly accessing it from the CurrentInstance.
- Adds a lookup to find the corresponding TabBarItem that contains the current instance
- Updates the navigation parameter retrieval to use the found TabBarItem
- Includes a descriptive comment explaining the purpose of the new lookup logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+143
to
+144
| var correspondingTabItem = ViewModel.AppInstances.FirstOrDefault(tabItem => tabItem.TabItemContent == e.CurrentInstance); | ||
| var navArgs = correspondingTabItem?.NavigationParameter?.NavigationParameter; |
There was a problem hiding this comment.
The FirstOrDefault lookup is performed every time the current instance changes. Consider caching this relationship or using a more efficient lookup mechanism if this event fires frequently during tab navigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.