Skip to content

Code Quality: Moved CheckAppUpdate() to run in a separate thread #17607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2025
Merged

Code Quality: Moved CheckAppUpdate() to run in a separate thread #17607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/Files.App/Helpers/Application/AppLifecycleHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,11 @@ await Task.WhenAll(

FileTagsHelper.UpdateTagsDb();

// Release notes tab doesn't open unless this is awaited
// Auto update doesn't work unless this is awaited
await CheckAppUpdate();
_ = Task.Run(async () =>
{
// The follwing method invokes UI thread, so we run it in a separate task
await CheckAppUpdate();
});

static Task OptionalTaskAsync(Task task, bool condition)
{
Expand Down Expand Up @@ -158,8 +160,11 @@ public static async Task CheckAppUpdate()
updateService.AreReleaseNotesAvailable &&
!ViewedReleaseNotes)
{
await Ioc.Default.GetRequiredService<ICommandManager>().OpenReleaseNotes.ExecuteAsync();
ViewedReleaseNotes = true;
await MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(async () =>
{
await Ioc.Default.GetRequiredService<ICommandManager>().OpenReleaseNotes.ExecuteAsync();
ViewedReleaseNotes = true;
});
}

await updateService.CheckForUpdatesAsync();
Expand Down
Loading