Skip to content

Conversation

@seer-by-sentry
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. The issue was that: Double string formatting: ICU MessageFormat output re-processed by .NET's string.Format causes FormatException due to incompatible syntax.
  2. Removed redundant switch statements that were formatting the header and subheader strings based on the operation result.
  3. The header and subheader strings are now directly assigned after being formatted with the appropriate parameters.

This fix was generated by Seer in Sentry, triggered by Yair. 👁️ Run ID: 1481234

Not quite right? Click here to continue debugging with Seer.

@yaira2 yaira2 changed the title Refactor: Simplify Status Center card header and subheader creation Code Quality: Simplify Status Center card header and subheader creation Sep 18, 2025
@yaira2 yaira2 marked this pull request as ready for review September 18, 2025 15:09
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 18, 2025
@yaira2 yaira2 merged commit 6319362 into main Sep 18, 2025
9 checks passed
@yaira2 yaira2 deleted the seer/refactor-status-center-card-strings branch September 18, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants