Skip to content

Fix: Fixed an issue where incorrect actions were displayed in the Recycle Bin context menu #17813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2025
Merged

Fix: Fixed an issue where incorrect actions were displayed in the Recycle Bin context menu #17813

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
11d6a17
Fix: Hidden inappropriate context menu items for Recycle Bin.
workbysaran Oct 30, 2025
7814546
Fix: Hidden inappropriate context menu items for Recycle Bin items.
workbysaran Oct 30, 2025
9849acb
Fix: Set IsExecutable property for navigation actions to prevent exec…
workbysaran Oct 31, 2025
75908c5
Code Quality: Removed redundant RecycleBin checks from context menu f…
workbysaran Nov 3, 2025
4cfff81
Fix: Fixed RecycleBin blocking for Open, Open With, and Pin to Sidebar
workbysaran Nov 3, 2025
0ac06d4
Code Quality: Removed redundant RecycleBin check from CreateFolderWit…
workbysaran Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Files.App/Actions/FileSystem/OpenItemAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ public HotKey HotKey
public bool IsExecutable =>
context.HasSelection &&
!(context.ShellPage is ColumnShellPage &&
context.SelectedItem?.PrimaryItemAttribute == StorageItemTypes.Folder);
context.SelectedItem?.PrimaryItemAttribute == StorageItemTypes.Folder) &&
context.PageType != ContentPageTypes.RecycleBin;

public OpenItemAction()
{
Expand Down Expand Up @@ -67,6 +68,7 @@ public RichGlyph Glyph

public bool IsExecutable =>
context.HasSelection &&
context.PageType != ContentPageTypes.RecycleBin &&
context.SelectedItems.All(i =>
(i.PrimaryItemAttribute == StorageItemTypes.File && !i.IsShortcut && !i.IsExecutable) ||
(i.PrimaryItemAttribute == StorageItemTypes.Folder && i.IsArchive));
Expand Down
1 change: 1 addition & 0 deletions src/Files.App/Actions/Navigation/OpenInNewPane/BaseOpenInNewPaneAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public string Description
=> Strings.OpenDirectoryInNewPaneDescription.GetLocalizedResource();

public virtual bool IsExecutable =>
ContentPageContext.PageType != ContentPageTypes.RecycleBin &&
ContentPageContext.SelectedItem is not null &&
ContentPageContext.SelectedItem.IsFolder;

Expand Down
1 change: 1 addition & 0 deletions src/Files.App/Actions/Navigation/OpenInNewTab/BaseOpenInNewTabAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public virtual bool IsAccessibleGlobally
public virtual bool IsExecutable =>
ContentPageContext.ShellPage is not null &&
ContentPageContext.ShellPage.SlimContentPage is not null &&
ContentPageContext.PageType != ContentPageTypes.RecycleBin &&
ContentPageContext.SelectedItems.Count is not 0 &&
ContentPageContext.SelectedItems.Count <= 5 &&
ContentPageContext.SelectedItems.Count(x => x.IsFolder) == ContentPageContext.SelectedItems.Count;
Expand Down
1 change: 1 addition & 0 deletions src/Files.App/Actions/Navigation/OpenInNewWindow/BaseOpenInNewWindowAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public virtual bool IsAccessibleGlobally
public virtual bool IsExecutable =>
ContentPageContext.ShellPage is not null &&
ContentPageContext.ShellPage.SlimContentPage is not null &&
ContentPageContext.PageType != ContentPageTypes.RecycleBin &&
ContentPageContext.SelectedItems.Count is not 0 &&
ContentPageContext.SelectedItems.Count <= 5 &&
ContentPageContext.SelectedItems.Count(x => x.IsFolder) == ContentPageContext.SelectedItems.Count;
Expand Down
3 changes: 3 additions & 0 deletions src/Files.App/Actions/Sidebar/PinFolderToSidebarAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ public async Task ExecuteAsync(object? parameter = null)

private bool GetIsExecutable()
{
if (context.PageType == ContentPageTypes.RecycleBin)
return false;

string[] pinnedFolders = [.. App.QuickAccessManager.Model.PinnedFolders];

return context.HasSelection
Expand Down
2 changes: 1 addition & 1 deletion src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(
}.Build(),
new ContextMenuFlyoutItemViewModelBuilder(Commands.CreateFolderWithSelection)
{
IsVisible = UserSettingsService.GeneralSettingsService.ShowCreateFolderWithSelection && itemsSelected
IsVisible = UserSettingsService.GeneralSettingsService.ShowCreateFolderWithSelection && itemsSelected && !currentInstanceViewModel.IsPageTypeRecycleBin
}.Build(),
new ContextMenuFlyoutItemViewModelBuilder(Commands.CreateShortcut)
{
Expand Down
Loading