Skip to content

Fix: Display error dialog for file tag application failure on UI thread #17814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Display error dialog for file tag application failure on UI thread #17814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/Files.App/Utils/FileTags/FileTagsHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) Files Community
// Licensed under the MIT License.

using Files.App.Extensions;
using Microsoft.UI.Xaml.Controls;
using Windows.Foundation.Metadata;
using Windows.Storage;
Expand Down Expand Up @@ -40,17 +41,20 @@ public static async void WriteFileTag(string filePath, string[] tag)
var result = Win32Helper.WriteStringToFile($"{filePath}:files", string.Join(',', tag));
if (result == false)
{
ContentDialog dialog = new()
await MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(async () =>
{
Title = Strings.ErrorApplyingTagTitle.GetLocalizedResource(),
Content = Strings.ErrorApplyingTagContent.GetLocalizedResource(),
PrimaryButtonText = "Ok".GetLocalizedResource()
};
ContentDialog dialog = new()
{
Title = Strings.ErrorApplyingTagTitle.GetLocalizedResource(),
Content = Strings.ErrorApplyingTagContent.GetLocalizedResource(),
PrimaryButtonText = "Ok".GetLocalizedResource()
};

if (ApiInformation.IsApiContractPresent("Windows.Foundation.UniversalApiContract", 8))
dialog.XamlRoot = MainWindow.Instance.Content.XamlRoot;
if (ApiInformation.IsApiContractPresent("Windows.Foundation.UniversalApiContract", 8))
dialog.XamlRoot = MainWindow.Instance.Content.XamlRoot;

await dialog.TryShowAsync();
await dialog.TryShowAsync();
});
}
}
if (isReadOnly) // Restore read-only attribute (#7534)
Expand Down
Loading