Skip to content

Feature: Add 7z dictionary and word size options#18232

Open
yair100 wants to merge 3 commits intomainfrom
ya/7zUpdate
Open

Feature: Add 7z dictionary and word size options#18232
yair100 wants to merge 3 commits intomainfrom
ya/7zUpdate

Conversation

@yair100
Copy link
Member

@yair100 yair100 commented Mar 9, 2026

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

@yair100 yair100 requested a review from Josh65-2201 March 9, 2026 03:13
@yair100 yair100 added the ready for review Pull requests that are ready for review label Mar 9, 2026
Josh65-2201
Josh65-2201 previously approved these changes Mar 9, 2026
Copy link
Member

@Josh65-2201 Josh65-2201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.
I would recommend adding estimated memory usage as with these options you can go well above what the system has available causing Files/the system to lag or crash. 7zip will show it has amount used for compression/what you have available (it only checks once when the dialog is opened)/total installed

Copy link
Member

@Josh65-2201 Josh65-2201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The estimated memory usage it quite low to what is actually gets used. Based on Task manager shows with the same settings in both
7zip estimates 13.89GB and uses that.
Files estimates 3.32GB uses about 15.5GB (Removing what Files uses based on amount before compression started)
image

@yair100 yair100 requested a review from Josh65-2201 March 11, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add word and dictionary size control for 7z archive creation

2 participants