Update store.browser.ts to handle window.localStorage access error#527
Open
BenMuschol-at wants to merge 1 commit intofilestack:masterfrom
Open
Update store.browser.ts to handle window.localStorage access error#527BenMuschol-at wants to merge 1 commit intofilestack:masterfrom
BenMuschol-at wants to merge 1 commit intofilestack:masterfrom
Conversation
|
This is a vital change for our use-case as well. Steps to reproduce:In Firefox 119 set the browser privacy to "Custom" and set blocked "Cookies" to "All cross-site cookies". Embed the filestack-code in a website that is then embedded in an iFrame on a different domain. Now accessing the localStorage will fail with error "Error: Failed to read the 'localStorage' property from 'Window': Access is denied for this document" or similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🐛 Bug fix
window.localStoragecrashes in an iframe with anAccess Deniederror. The code is already resilient tolocalStoragenot existing, it's just not resilient tolocalStoragethrowing an error. This PR includes a minor code structure change so that it handles this case.Does not crash in iframes, properly falls back to other storage