Skip to content

Conversation

fvanzee
Copy link

@fvanzee fvanzee commented Nov 25, 2017

Removes obsolete Get signature.
Updates Core library to Framework 4.5 to better facilitate Task methods.
IApiOutputCache usages and implementations are adjusted to use the updated interface.

This relates to the request to update the interface to have async signatures #158

I hope this is the approach you were aiming at.

@sajibcefalo
Copy link

When will be this pull request merged?

@ErroneousFatality
Copy link

@filipw Could you please comment if you plan on adding this functionality to your library or not, so we know whether to keep using it.

@filipw
Copy link
Owner

filipw commented Jan 21, 2019

I think this is a good change - would you be so kind and rebase this on top of the latest master?
I would normally like to avoid breaking changes too but I think this is OK in this case. Unfortunately when the original interface was created, Web API was sync only 😀

@fvanzee fvanzee force-pushed the feature/outputcache-api-async branch from cb4bb80 to 9c9f56b Compare January 21, 2019 19:56
@fvanzee fvanzee changed the base branch from dev to master January 21, 2019 19:58
@fvanzee
Copy link
Author

fvanzee commented Jan 21, 2019

Thanks for the review!

I'm not sure if I should've rebased this on master. Was this what you wanted?
Let me know how you would like it. I branched off of dev, so it looks like this PR is now including some commits that are not part of this PR.

@filipw
Copy link
Owner

filipw commented Jan 22, 2019

oops sorry I meant dev indeed 🙈😱

Freek van Zee added 2 commits January 22, 2019 22:45
Removes obsolete Get signature.
Updates Core library to Framework 4.5 to better facilitate
Task methods.
IApiOutputCache usages and implementations are adjusted
to use the updated interface.
@fvanzee fvanzee force-pushed the feature/outputcache-api-async branch from 9c9f56b to a2b7597 Compare January 22, 2019 21:45
@fvanzee fvanzee changed the base branch from master to dev January 22, 2019 21:46
@fvanzee
Copy link
Author

fvanzee commented Jan 22, 2019

oops sorry I meant dev indeed 🙈😱

Sorry about that too, I should've asked before I updated my branch.

All should be sorted now.
Rebased on dev and comments resolved.

@filipw
Copy link
Owner

filipw commented Jan 23, 2019

thanks a lot - before merging, I will set up CI for this project separately because the old one stopped working

@djavier
Copy link

djavier commented Oct 15, 2019

Hi @filipw, any new status on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants