-
Notifications
You must be signed in to change notification settings - Fork 253
Update IApiOutputCache to Async signatures #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
When will be this pull request merged? |
@filipw Could you please comment if you plan on adding this functionality to your library or not, so we know whether to keep using it. |
I think this is a good change - would you be so kind and rebase this on top of the latest master? |
cb4bb80
to
9c9f56b
Compare
Thanks for the review! I'm not sure if I should've rebased this on master. Was this what you wanted? |
oops sorry I meant dev indeed 🙈😱 |
Removes obsolete Get signature. Updates Core library to Framework 4.5 to better facilitate Task methods. IApiOutputCache usages and implementations are adjusted to use the updated interface.
9c9f56b
to
a2b7597
Compare
Sorry about that too, I should've asked before I updated my branch. All should be sorted now. |
thanks a lot - before merging, I will set up CI for this project separately because the old one stopped working |
Hi @filipw, any new status on this? |
Removes obsolete Get signature.
Updates Core library to Framework 4.5 to better facilitate Task methods.
IApiOutputCache usages and implementations are adjusted to use the updated interface.
This relates to the request to update the interface to have async signatures #158
I hope this is the approach you were aiming at.