Skip to content

Conversation

@Ruchika-2003
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 71.36465% with 128 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Galley/TensorStats/DCStats.jl 73.65% 103 Missing ⚠️
src/Galley/TensorStats/NaiveStats.jl 55.35% 25 Missing ⚠️
Files with missing lines Coverage Δ
src/Galley/TensorStats/propagate-stats.jl 72.72% <ø> (-8.38%) ⬇️
src/Galley/TensorStats/tensor-stats.jl 83.50% <ø> (+12.65%) ⬆️
src/Galley/TensorStats/NaiveStats.jl 55.35% <55.35%> (ø)
src/Galley/TensorStats/DCStats.jl 73.65% <73.65%> (ø)

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to run JuliaFormatter to pass tests. See contributing.md

@willow-ahrens
Copy link
Member

willow-ahrens commented Nov 20, 2025

errors with "BlockedStats not defined"

  1. Please test locally, you can reduce test time by running specific test suites (e.g. galley), or running in parallel, please see contributing.md for more info
  2. Have you been developing your BlockedStats feature on the main branch of your fork? In general, it's bad practice to develop features on your main, because it makes things more difficult when your main branch is out of sync with finch-tensor:main. If your PR isn't merged, or if you need to pull from finch-tensor:main and merge it into your feature branch, things can get tricky. My recommendation is to undo the last commit and force push to this branch, then rename your main branch to some feature name like ruchika/blockedstats, then pull finch-tensor/Finch.jl-main into your repo, then force push it to your main. Please see GitHub's pull request guide for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants