Skip to content

Conversation

@junikimm717
Copy link
Collaborator

Creating a Hash Table Type with STC

  • Numba and C backends have completely different logic

@junikimm717
Copy link
Collaborator Author

junikimm717 commented Nov 29, 2025

@willow-ahrens
Could I get some help with some issues relating to mypy and numba?
It appears that mypy suddenly refuses to believe that numba.types is a module that exists 💀
All other tests pass though

@junikimm717 junikimm717 marked this pull request as ready for review November 29, 2025 00:26
@junikimm717 junikimm717 changed the title Junikimm717/hashtable Integer Tuple to Integer Tuple Hash Tables Nov 29, 2025
Even though literally everything should be immutable right now
@mtsokol
Copy link
Member

mtsokol commented Dec 2, 2025

@junikimm717 I've got one major request before reviewing it: Can you remove all copied stc files/directory and make it a git submodule? Here's a particular project that does it: https://github.com/pyccel/pyccel/tree/devel/pyccel/extensions

https://git-scm.com/book/en/v2/Git-Tools-Submodules

@mtsokol mtsokol force-pushed the junikimm717/hashtable branch from 18459a6 to 1abae19 Compare December 2, 2025 12:22
@mtsokol mtsokol self-requested a review December 2, 2025 12:23
@junikimm717
Copy link
Collaborator Author

Wait @mtsokol one possible concern is that these files are technically build artifacts from the STC build system...
I'll investigate if I can just get away with slipping in the repository though

@mtsokol
Copy link
Member

mtsokol commented Dec 2, 2025

one possible concern is that these files are technically build artifacts from the STC build system... I'll investigate if I can just get away with slipping in the repository though

When you fetch submodules the files are there so it doesn't matter from the build process POV.

@junikimm717
Copy link
Collaborator Author

Yeah seems so
Tests still pass :)

On another note, I'm actually waiting on #248 to get merged into main before this PR
I have done this PR with the assumption that 248 passes (otherwise the design just can't work)

@mtsokol
Copy link
Member

mtsokol commented Dec 2, 2025

SG, let's move #248 in first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants