-
Notifications
You must be signed in to change notification settings - Fork 8
Integer Tuple to Integer Tuple Hash Tables #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Turn immutable tuples into C structs, and keep mutable tuples as C pointers.
How is the numba compiler backend even more horrible than C
|
@willow-ahrens |
Even though literally everything should be immutable right now
|
@junikimm717 I've got one major request before reviewing it: Can you remove all copied stc files/directory and make it a git submodule? Here's a particular project that does it: https://github.com/pyccel/pyccel/tree/devel/pyccel/extensions |
18459a6 to
1abae19
Compare
|
Wait @mtsokol one possible concern is that these files are technically build artifacts from the STC build system... |
When you fetch submodules the files are there so it doesn't matter from the build process POV. |
|
Yeah seems so On another note, I'm actually waiting on #248 to get merged into main before this PR |
|
SG, let's move #248 in first. |
bad constructor
Creating a Hash Table Type with STC