Merged
Conversation
- Remove unused FindMineErrorResponse import, add FindMineProduct - Add proper interfaces for raw API responses (RawLook, RawCompleteTheLookResponse, RawErrorResponse) - Replace Record<string, any> with object type + explicit entry casting - Replace non-null assertions (!) with nullish coalescing defaults - Wrap numbers in String() for template literals - Add type guards for primitive values before stringification - Remove unnecessary optional chain on typed value - Normalize look data with proper RawLook typing instead of any
The "stop living in the SDK dark ages" release. Major changes: - Upgrade MCP SDK 0.6.0 -> 1.24.2 (finally in this decade) - Refactor index.ts from 1509 lines to 117 lines (92% diet success) - Add tool annotations (readOnlyHint, destructiveHint, openWorldHint) - Add Zod validation for all tool inputs (trust issues, but make it type-safe) New infrastructure: - Vitest testing with 45 unit tests (coverage: cache, formatters) - ESLint flat config + Prettier (the code now has standards) - GitHub Actions CI/CD pipeline (automation > manual labor) - CHANGELOG.md (because memory is fallible) Architecture: - src/handlers/ - request routing (resources, prompts, tools) - src/schemas/ - Zod input validation schemas - src/tools/ - tool definitions with MCP annotations - src/prompts/ - prompt templates - src/content/ - static content (style guides) Breaking: Internal restructure, external API unchanged.
- Add complete development scripts documentation - Document new modular project structure (handlers, tools, schemas) - Add testing section with Vitest coverage info - Add code quality section (ESLint, Prettier, pre-commit) - Document MCP SDK 1.24.2 compliance and tool annotations - Update CLAUDE.md with testing guidelines and architecture principles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full modernization of the FindMine MCP server from v0.1.1 to v0.2.0, bringing it up to 2025 standards.
Major Changes
index.ts(1509 lines) decomposed into modular components (117 lines)readOnlyHint,destructiveHint,openWorldHint)New Infrastructure
New Architecture
Test Plan
npm run build)npm run lint)npm test)npm run inspector)Breaking Changes
Internal architecture completely restructured, but external MCP API unchanged. Existing MCP clients should continue to work without modification.
Related