Skip to content

🥼 [gha] fixes for new markdownlint#102

Merged
chicks-net merged 1 commit intomainfrom
chicks/2026-02-22-new-markdownlint
Feb 22, 2026
Merged

🥼 [gha] fixes for new markdownlint#102
chicks-net merged 1 commit intomainfrom
chicks/2026-02-22-new-markdownlint

Conversation

@chicks-net
Copy link
Member

Done

  • 🥼 [gha] fixes for new markdownlint

Meta

(Automated in .just/gh-process.just.)

Copilot AI review requested due to automatic review settings February 22, 2026 23:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates markdown table formatting in test fixtures to comply with new markdownlint requirements. The changes add proper column padding to markdown tables to satisfy the table-pipe-alignment rule (MD055) that is enforced by newer versions of markdownlint-cli2.

Changes:

  • Updated markdown table formatting in PR body test fixtures to include proper column alignment padding

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.just/test/fixtures/pr_bodies/10_tables/input.md Added column padding to markdown table cells for proper alignment
.just/test/fixtures/pr_bodies/10_tables/expected.md Added column padding to markdown table cells for proper alignment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@claude
Copy link

claude bot commented Feb 22, 2026

Code Review

Summary

This PR updates two test fixture files to align markdown table columns, making them compatible with a newer version of markdownlint-cli2. The change is focused and correct.


What's changed

Both input.md and expected.md in .just/test/fixtures/pr_bodies/10_tables/ are updated to use padded, column-aligned table syntax:

Before:

| Test | Status | Notes |
|------|--------|-------|
| Test 1 | Pass | OK |

After:

| Test   | Status | Notes |
|--------|--------|-------|
| Test 1 | Pass   | OK    |

Strengths

  • Minimal and focused — only the two fixture files that needed updating were touched. No other fixture files contain tables, so nothing was missed.
  • Consistent update — both input.md and expected.md are updated identically. Since the PR body update logic does not reformat table content, keeping both files in sync is correct and the test continues to exercise the right behavior.
  • CI is green — lint, run, test, verify, actionlint, checkov, and scan all pass.

Suggestions

1. Document the specific markdownlint rule in .markdownlint.yml

The config uses default: True which enables all rules. It is not immediately clear which rule is now being enforced (likely MD055 or a table-alignment rule added in a recent markdownlint-cli2 release). Adding a comment or explicit rule entry would help future contributors understand why the fixtures look the way they do:

# MD055: Table pipe style (enabled by default, enforced by markdownlint-cli2 vX.Y)

This is a minor quality-of-life improvement, not a blocker.

2. Consider noting the markdownlint-cli2 version that introduced the requirement

The workflow uses DavidAnson/markdownlint-cli2-action@v22. If the intent is to track latest, that's fine, but formatting rules can silently tighten on future updates. Noting the version that introduced this requirement (in a commit message, changelog entry, or comment in .markdownlint.yml) would help trace future regressions.


Verdict

The change is correct and all checks pass. The suggestions above are optional improvements for maintainability. Ready to merge as-is.

@chicks-net chicks-net merged commit 9bb58d3 into main Feb 22, 2026
12 checks passed
@chicks-net chicks-net deleted the chicks/2026-02-22-new-markdownlint branch February 22, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants