workaround for knockout JS creation problem#130
Open
imrefazekas wants to merge 1 commit intofinnsson:masterfrom
imrefazekas:master
Open
workaround for knockout JS creation problem#130imrefazekas wants to merge 1 commit intofinnsson:masterfrom imrefazekas:master
imrefazekas wants to merge 1 commit intofinnsson:masterfrom
imrefazekas:master
Conversation
Open
Owner
|
I'm asking on the knockoutjs forum (https://groups.google.com/forum/#!topic/knockoutjs/ezZGzaF233A) what the recommended way forward is. |
Contributor
Author
|
Yep, saw it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Oscar,
I took the liberty to add a new function to the view model: toJSONByPrototype when the method extendWithPage is executed.
This allows one to generate the JS by a model prototype. When I download a data model from server side and create the viewmodel for knockout, I can use this as a "prototype" for JS creation.
This will prevent the knockout to go and touch properties which do not belong to the model.
Considering, that your library must be functional on almost any knockout lib, i post this change here and not to the knockout lib.