Fix bug when reloading page with parameters in URL#229
Open
SteffeyDev wants to merge 2 commits intofinnsson:masterfrom
Open
Fix bug when reloading page with parameters in URL#229SteffeyDev wants to merge 2 commits intofinnsson:masterfrom
SteffeyDev wants to merge 2 commits intofinnsson:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a fun one to track down.
First off, thanks for making and maintaining Pager, we use it on a fairly large web app (~30 pages) and haven't had too many issues so far. However, we did run into an issue that when you reload a nested page that has query params attached, it never loaded the page. I tracked down the bug to be on line 818. The issue was that the page being loaded (
m.getId()) wasTicket, but theparent.route[0]wasTicket?uid=<guid>, so because those did not match it did not triggerparent.showPageand thus the page was never shown.This fix is pretty straight forward, and I would appreciate if you can merge into the next release and let me know when it goes out on NPM so I can switch our project back to using this repo instead of my fork. Let me know if you want me to make any changes.