Increase WindowCloseWaitTimeout to 2 seconds#269
Increase WindowCloseWaitTimeout to 2 seconds#269thorsent wants to merge 2 commits intofinos:mainfrom
Conversation
There was a problem hiding this comment.
Hi @thorsent 👋
Seems fine to me.
Note this code also exists at https://github.com/finos/FDC3/blob/main/toolbox/fdc3-conformance/src/constants.ts
However, it looks like some past work on this framework was not merged back into it and @robmoffat has continued the development from an uncertain point (or perhaps with an uncertain number of past fixes that should have been merged back to main?) for the 2.2 changes:

I'm not sure what is being done to sort that out currently... Once done this project should be archived.
For now I would suggest also making this change at: https://github.com/finos/FDC3/blob/main/toolbox/fdc3-conformance/src/constants.ts
|
Thanks @kriswest , I wasn't aware the conformance tests had been consolidated into the fdc3 repo. I've pushed a PR with a corresponding change. |
|
I've raised #270 |
The former timeout period of 1 second was not enough to guarantee that test windows were closed before the next test began (e.g. when running conformance tests in CI on slow VDIs).