fix: align FDC3 web demo implementation metadata with current behavior#1801
Merged
kriswest merged 2 commits intofinos:mainfrom Mar 20, 2026
Merged
fix: align FDC3 web demo implementation metadata with current behavior#1801kriswest merged 2 commits intofinos:mainfrom
kriswest merged 2 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
27 tasks
kriswest
requested changes
Mar 20, 2026
Contributor
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
Hi @saschabuehrle, many thanks for your contribution. I've just discovered a small bug in the FDC3 fdc3-agent-proxy lib (#1802) that is causing the issue with OriginatingAppMetadata - hence I was incorrect about the reference implementation not supporting that. Could you revert that change and then I'll merge this.
| optionalFeatures: { | ||
| DesktopAgentBridging: false, | ||
| OriginatingAppMetadata: true, | ||
| OriginatingAppMetadata: false, |
Contributor
There was a problem hiding this comment.
This change should be reverted (my bad)
Suggested change
| OriginatingAppMetadata: false, | |
| OriginatingAppMetadata: true, |
Contributor
Author
|
Thanks for the heads-up. I reverted the OriginatingAppMetadata support toggle and pushed the update to this PR in commit 450d86c.\n\nGreetings, saschabuehrle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes #1795. The FDC3 for Web demo reported outdated implementation metadata values and incorrectly advertised
OriginatingAppMetadatasupport.Fix
0.1to2.2.22.0to2.2optionalFeatures.OriginatingAppMetadatafromtruetofalsein the FDC3 web implementation metadata payloadThese updates align the demo metadata with the current implementation behavior.
Greetings, saschabuehrle