Change Logger for Node Js and Browser Compatibility#1186
Merged
aidanm3341 merged 5 commits intofinos:mainfrom May 13, 2025
Merged
Change Logger for Node Js and Browser Compatibility#1186aidanm3341 merged 5 commits intofinos:mainfrom
aidanm3341 merged 5 commits intofinos:mainfrom
Conversation
Member
|
@Adwoa-Konadu-Appiah please check you have the package-lock file synced. |
Adwoa-Konadu-Appiah
requested review from
a team,
LeighFinegold,
Thels,
aidanm3341,
grahampacker-ms,
jpgough-ms,
lbulanti-ms,
rocketstack-matt and
willosborne
as code owners
aidanm3341
reviewed
May 2, 2025
aidanm3341
reviewed
May 2, 2025
aidanm3341
reviewed
May 2, 2025
aidanm3341
reviewed
May 2, 2025
aidanm3341
reviewed
May 2, 2025
aidanm3341
approved these changes
May 13, 2025
Adwoa-Konadu-Appiah
changed the title
| * @returns Logger instance | ||
| */ | ||
| export function initLogger(debug: boolean, label?: string): Logger { | ||
| if (loggerInstance) return loggerInstance; |
Member
There was a problem hiding this comment.
Introducing state means the same format log line is used for all of the cli e.g. 0.7.8 of the cli it seems to be info [_TemplateEngine]:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to #1159, I have updated the logger to use the right logging model for Node.js and browser using the loglevel library.