Proposal to implement #1083#1195
Merged
rocketstack-matt merged 3 commits intofinos:mainfrom Apr 24, 2025
Merged
Conversation
Member
|
More a comment on creating schema proposals, it would be helpful to create the current structure in a first PR - so that the diffs of the change can be viewed more precisely. |
jpgough-ms
requested changes
Apr 24, 2025
Member
jpgough-ms
left a comment
There was a problem hiding this comment.
Overall, think this looks good. I've asked a few questions that would be good to clarify before approving
Member
Author
Agreed, I realised this when trying to review it myself. |
jpgough-ms
approved these changes
Apr 24, 2025
This was referenced Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This schema change is following the proposal for #893
If accepted, the following changes will likely be needed:
1. Update Validation Logic
The validation process in
shared/src/commands/validate/validate.tsneeds to be enhanced to:2. Update Spectral Rules
Modify Spectral validation functions in
shared/src/spectral/functions/architecture/:interface-id-exists.tsto extract unique-ids from both interface formatsinterface-id-exists-on-node.tsto check references with both formats3. Testing Implementation
4. Documentation Updates