Potential fix for code scanning alert no. 37: Workflow does not contain permissions#1482
Closed
rocketstack-matt wants to merge 1 commit intomainfrom
Closed
Potential fix for code scanning alert no. 37: Workflow does not contain permissions#1482rocketstack-matt wants to merge 1 commit intomainfrom
rocketstack-matt wants to merge 1 commit intomainfrom
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a code scanning security alert by adding explicit permissions to the GitHub workflow. The change sets minimal required permissions for the GITHUB_TOKEN to follow security best practices.
- Adds
permissionsblock withcontents: readto restrict GITHUB_TOKEN permissions - Follows the principle of least privilege for workflow security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/finos/architecture-as-code/security/code-scanning/37
To fix the problem, add a
permissionsblock to the workflow or the specific job to explicitly set the minimal required permissions for the GITHUB_TOKEN. In this case, the workflow only needs to check out code and interact with AWS (using secrets), but does not need to write to the repository or interact with issues, pull requests, or other resources. Therefore, settingcontents: readis sufficient and recommended. The best place to add this is at the top level of the workflow file, just after thenamefield, so it applies to all jobs in the workflow. No additional imports or definitions are needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.