build(cli): introducing Semantic-Version to control the CLI version#1515
Closed
Thels wants to merge 4 commits intofinos:mainfrom
Closed
build(cli): introducing Semantic-Version to control the CLI version#1515Thels wants to merge 4 commits intofinos:mainfrom
Thels wants to merge 4 commits intofinos:mainfrom
Conversation
Allow commits to formed in such a way that it will automatically manage our version of the CLI & maintain a CHANGELOG.md for us. fix finos#1011
Thels
requested review from
a team,
LeighFinegold,
aidanm3341,
grahampacker-ms,
jpgough-ms,
lbulanti-ms,
markscott-ms,
rocketstack-matt and
willosborne
as code owners
Contributor
|
cli/src/cli.e2e.spec.ts contains a test that explicitly checks the result of “calm —version” Will this continually break that test? |
Member
Author
Yes, but at the point where the version is controlled by commits it feels needless to have a test like that. |
Member
Author
|
I'll get some time later this evening to fix this PR - but hoping we can get it in for development being done post 1.0 to aid in the version management. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow commits to formed in such a way that it will automatically manage our version of the CLI & maintain a CHANGELOG.md for us.
fix #1011