Clean up most of the projects problem warnings

[rocketstack-matt]

This pull request focuses on improving type safety and consistency when retrieving lists and maps from MongoDB and Nitrite database documents throughout the codebase. The main changes involve replacing unchecked casts with type-safe retrieval methods, primarily using getList and a new TypeSafeNitriteDocument utility. Additionally, there are corrections to map handling for schema retrieval.

Type-safe retrieval improvements (MongoDB stores):

• Replaced unchecked casts like (List<Document>) result.get("...") with result.getList("...", Document.class) in all relevant methods for architectures, patterns, flows, standards, and ADRs, ensuring safer and more reliable data extraction from MongoDB documents.

Type-safe retrieval improvements (Nitrite stores):

• Introduced and applied TypeSafeNitriteDocument for extracting lists from Nitrite documents in ADR and Architecture stores, replacing direct usage of get(..., List.class) and reducing the risk of class cast exceptions.

Schema map retrieval correction:

• Fixed the logic in MongoCoreSchemaStore for retrieving the schemas map, ensuring all keys are properly cast to String and values are preserved, correcting a previous bug that resulted in empty maps.

Code cleanup:

• Removed unused variables from NitriteDBConfig.initializeDatabase() for clarity and maintainability.

Dependency and import updates:

• Added necessary imports for TypeSafeNitriteDocument and HashMap in affected files.

NO INTENDED FUNCTIONAL CHANGES

[Copilot]

Pull Request Overview

This pull request improves type safety and consistency in database document retrieval across MongoDB and Nitrite implementations. The changes replace unchecked casts with type-safe retrieval methods and fix schema map handling logic.

• Replaced unchecked casts (List<Document>) result.get("...") with type-safe result.getList("...", Document.class) in MongoDB stores
• Introduced TypeSafeNitriteDocument utility for safe list/map extraction from Nitrite documents
• Fixed schema map retrieval bug in MongoCoreSchemaStore that was causing empty maps

Reviewed Changes

Copilot reviewed 32 out of 33 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
TypeSafeNitriteDocument.java	New utility class for type-safe document field extraction
TestTypeSafeNitriteDocumentShould.java	Test coverage for the new utility class
MongoDB store classes	Updated to use type-safe getList method instead of unchecked casts
Nitrite store classes	Updated to use TypeSafeNitriteDocument for safe field extraction
MongoCoreSchemaStore.java	Fixed schema map retrieval logic to properly handle key-value pairs
NitriteDBConfig.java	Removed unused variables for code cleanup
Test files	Import reorganization and interface introduction for type safety