Skip to content

chore(calm): Delete old drafts#1761

Merged
jpgough-ms merged 4 commits intofinos:mainfrom
rocketstack-matt:calm-cleanup
Nov 6, 2025
Merged

chore(calm): Delete old drafts#1761
jpgough-ms merged 4 commits intofinos:mainfrom
rocketstack-matt:calm-cleanup

Conversation

@rocketstack-matt
Copy link
Member

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🎨 Code style/formatting changes
  • ♻️ Refactoring (no functional changes)
  • ⚡ Performance improvements
  • ✅ Test additions or updates
  • 🔧 Chore (maintenance, dependencies, CI, etc.)

Affected Components

  • CLI (cli/)
  • Shared (shared/)
  • CALM Widgets (calm-widgets/)
  • CALM Hub (calm-hub/)
  • CALM Hub UI (calm-hub-ui/)
  • Documentation (docs/)
  • VS Code Extension (calm-plugins/vscode/)
  • Dependencies
  • CI/CD
  • CALM Schema

Commit Message Format ✅

Testing

  • I have tested my changes locally
  • I have added/updated unit tests
  • All existing tests pass

Checklist

  • My commits follow the conventional commit format
  • I have updated documentation if necessary
  • I have added tests for my changes (if applicable)
  • My changes follow the project's coding standards

Copilot AI review requested due to automatic review settings October 28, 2025 14:19
@rocketstack-matt rocketstack-matt requested a review from a team as a code owner October 28, 2025 14:19
@github-actions github-actions bot added the calm label Oct 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated draft versions of the CALM schema specification, cleaning up the repository by deleting outdated schema definitions, sample files, and prototypes. The changes focus on removing three draft versions (2025-03, 2025-01, and multiple 2024-* versions) along with their associated metadata, examples, and prototype implementations.

  • Removes draft/2025-03 schema version including meta schemas, sample control requirements, and prototypes
  • Removes draft/2025-01 and all 2024-* draft versions (2024-12, 2024-10, 2024-09, 2024-08, 2024-04, 2024-03, 2024-02)
  • Removes experimental draft versions (draft/1233, draft/1232, draft/1224, draft/1177) with their prototypes and documentation

Reviewed Changes

Copilot reviewed 120 out of 120 changed files in this pull request and generated no comments.

Show a summary per file
File Description
calm/draft/2025-03/* Removes 2025-03 draft including all meta schemas, sample control requirements, prototypes, and README
calm/draft/2025-01/* Removes 2025-01 draft meta schemas
calm/draft/2024-/ Removes all 2024 draft versions (12, 10, 09, 08, 04, 03, 02) and their meta schemas
calm/draft/1233/* Removes experimental inline control configuration draft with prototypes and documentation
calm/draft/1232/* Removes experimental core.json schema draft
calm/draft/1224/* Removes ADR support prototype and documentation
calm/draft/1177/* Removes authentication control prototype files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@markscott-ms
Copy link
Contributor

markscott-ms commented Oct 28, 2025

I'm concerned that whilst the removed schema versions are not official releases, there may be reference to them in the wild, particularly 2025-03, and removal could break validation of patterns and/or architectures dependent on them.

But:

  • These are non official release versions
  • Only updated CLIs are impacted
  • Workarounds are possible by having a local copy of the draft schema and the --schema-directory CLI option.

markscott-ms
markscott-ms previously approved these changes Oct 28, 2025
Copy link
Contributor

@markscott-ms markscott-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because these were non-official schema and there are workarounds if dependencies exist on them and user is unable to update immediately to the 1.0 schema

@rocketstack-matt rocketstack-matt marked this pull request as draft October 28, 2025 17:05
@rocketstack-matt
Copy link
Member Author

Marking as draft to block merge awaiting some community feedback

@rocketstack-matt
Copy link
Member Author

Note that calm/drafts/2025-03 has been restored in this PR for now, as requested by community. It will be removed in a later PR.

@jpgough-ms jpgough-ms marked this pull request as ready for review November 6, 2025 13:09
@jpgough-ms jpgough-ms merged commit 6acbc6d into finos:main Nov 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants