Skip to content

docs: add explicit CALM validation instructions to chat mode #1795

Merged
markscott-ms merged 2 commits intofinos:mainfrom
gkaria:docupdates
Nov 11, 2025
Merged

docs: add explicit CALM validation instructions to chat mode #1795
markscott-ms merged 2 commits intofinos:mainfrom
gkaria:docupdates

Conversation

@gkaria
Copy link
Contributor

@gkaria gkaria commented Nov 11, 2025

Summary

This PR adds explicit CALM schema validation instructions to the Architecture Creation Guide, resolving a documentation gap in chat mode to mandate validation of architecture json files.

Problem

The architecture-creation guide included a validation checklist item but provided no actual instructions on how to perform validation. This was inconsistent with other CALM creation guides and left agent unclear about which command to run or how to interpret results.

Solution

Added a MANDATORY VALIDATION section to the checklist that includes:

  • The specific calm validate command syntax
  • Clear success criteria with expected output format
  • Instructions to review validation errors and fix them before proceeding
  • Reminder to document any warnings addressed

Changes

  • Added explicit validation steps to the Architecture Creation Checklist
  • Included command: calm validate -a <filename>.architecture.json
  • Added success criteria showing expected output (hasErrors: false, hasWarnings: false)
  • Emphasized that JSON validity does not guarantee CALM validity

Testing

  • Tested these validation instructions against the calm-cli tool and confirmed they produce valid validation output
  • Verified the documentation is clear and follows the pattern used in other CALM guides
  • Confirmed the command syntax matches the calm-cli tool requirements
  • Tested these instructions in a separate project and confirm they work as documented

Related Issue

Fixes #1793

Checklist

  • Documentation is clear and follows existing patterns
  • Changes align with other CALM creation guides
  • Instructions have been tested and verified
  • Related issue is referenced

…ion guide

The architecture-creation guide previously included a checklist item for
validation but lacked actual instructions on how to perform it. This created
inconsistency with other CALM guides (pattern-creation.md,
documentation-creation.md) that include explicit validation commands.

Add comprehensive validation steps including:
- calm validate command with proper syntax
- Clear success criteria (hasErrors: false, hasWarnings: false)
- Guidance to review and fix errors before proceeding
- Instructions to document any warnings addressed

Fixes finos#1793
@gkaria gkaria requested a review from a team as a code owner November 11, 2025 10:19
@markscott-ms markscott-ms merged commit 8a67913 into finos:main Nov 11, 2025
12 checks passed
pmerrison pushed a commit to pmerrison/architecture-as-code that referenced this pull request Nov 20, 2025
docs: add explicit CALM validation instructions to chat mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CALM Copilot Chat - Architecture creation guide missing explicit validation command

3 participants