Skip to content

fix(shared): escape backslashes before quotes in template preprocessor #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeighFinegold merged 2 commits into from
Nov 27, 2025
Merged

fix(shared): escape backslashes before quotes in template preprocessor #1866

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b5c88c
fix(shared): escape backslashes before quotes in template preprocessor
rocketstack-matt Nov 27, 2025
83c62b6
Merge branch 'main' into fix/shared-incomplete-string-escaping
rocketstack-matt Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared/src/template/template-preprocessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ export class TemplatePreprocessor {
return { decision: { kind: 'leave', seg, reason: 'native-handlebars-path' } };
}

const safePath = path.replace(/"/g, '\\"');
const safePath = path.replace(/\\/g, '\\\\').replace(/"/g, '\\"');
Copy link

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This security fix for CWE-116 (incomplete string escaping) lacks test coverage. Consider adding a test case that verifies paths containing backslashes are properly escaped. For example:

it('escapes backslashes in paths to prevent quote bypass', () => {
    const input = '{{list foo\\bar}}';
    const output = TemplatePreprocessor.preprocessTemplate(input);
    expect(output).toBe('{{list (convertFromDotNotation this "foo\\\\bar")}}');
});

it('escapes backslashes before quotes in paths', () => {
    const input = '{{nodes[\\"test\\"]}}';
    const output = TemplatePreprocessor.preprocessTemplate(input);
    expect(output).toBe('{{convertFromDotNotation this "nodes[\\\\\\"test\\\\\\"]"}}');
});

Without tests, it's difficult to verify the fix works correctly and prevent regression in the future.

Copilot uses AI. Check for mistakes.
const { kvs, positionals } = TemplatePreprocessor.splitExtrasFromString(extras);
const kvsPart = kvs.length ? ` ${kvs.join(' ')}` : '';
const posPart = positionals.length ? ` ${positionals.join(' ')}` : '';
Expand Down
Loading