CLI validation - permit zero or false properties#1877
Merged
rocketstack-matt merged 5 commits intofinos:mainfrom Nov 28, 2025
Merged
CLI validation - permit zero or false properties#1877rocketstack-matt merged 5 commits intofinos:mainfrom
rocketstack-matt merged 5 commits intofinos:mainfrom
Conversation
Contributor
Author
|
This PR will remain in draft as I highly suspect a merge conflict will be caused when #1872 is merged as similar lines have been modified. |
# Conflicts: # shared/src/commands/validate/validate.e2e.spec.ts
rocketstack-matt
requested changes
Nov 28, 2025
rocketstack-matt
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Whilst testing the Advent of CALM, a property with a
falsevalue was created. There are reasonable circumstances where this would be appropriate.However, there is a spectral rule that raises an error for any empty string, zero number or non-true property anywhere in the architecture.
This PR relaxes the spectral rule to only consider strings, i.e. properties with the value
"".{ "metadata" : { "minimum-instances": 0 } }{ "metadata" : { "data-encrypted-at-rest": false } }Type of Change
Affected Components
cli/)shared/)calm-widgets/)calm-hub/)calm-hub-ui/)docs/)calm-plugins/vscode/)Commit Message Format ✅
Testing
Checklist