fix(docs): really fix the links in Advent of CALM#1892
Merged
rocketstack-matt merged 1 commit intofinos:mainfrom Nov 29, 2025
Merged
fix(docs): really fix the links in Advent of CALM#1892rocketstack-matt merged 1 commit intofinos:mainfrom
rocketstack-matt merged 1 commit intofinos:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes relative link issues in the Advent of CALM documentation by ensuring that the development environment mirrors production behavior with respect to trailing slashes and directory-based routing. The changes update all relative links to work correctly with Astro's trailingSlash: 'always' configuration.
Key Changes:
- Added
trailingSlash: 'always'to Astro config to enforce consistent URL handling in dev and prod - Updated all navigation links to use proper relative paths with trailing slashes
- Adjusted Calendar component links to work with directory-based routing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| astro.config.mjs | Added trailingSlash: 'always' configuration to ensure dev environment mirrors production behavior |
| Calendar.astro | Updated day links from ./day/${day} to day/${day}/ to work correctly with directory-based routing |
| day/[day].astro | Updated all navigation links (prev/next/home) to use correct relative paths with trailing slashes for directory-based routing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rocketstack-matt
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and make dev mirror prod behaviour
Description
Okay, so astro can be annoying. In prod (disted) mode, we have pages going to directories, and it redirects requests for
/day/2to/day/2/.In dev it doesn't do that redirect, it serves the content on both routes.
This is an absolute pain for relative links.
This PR fixes it, and also disables the non-directory route in dev.
Type of Change
Affected Components
cli/)shared/)calm-widgets/)calm-hub/)calm-hub-ui/)docs/)calm-plugins/vscode/)Commit Message Format ✅
Testing
Checklist