Skip to content

fix #1891 - support wider range of characters in relationship labels #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markscott-ms wants to merge 1 commit into from
Closed

fix #1891 - support wider range of characters in relationship labels #1893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion calm-widgets/src/widgets/block-architecture/block-architecture.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ classDef system fill:#fff8e1,stroke:#f9a825,stroke-width:2px,color:#000;

{{!-- Edges --}}
{{#each edges}}
{{{mermaidId source}}} -->{{#if label}}|{{label}}|{{/if}} {{{mermaidId target}}}
{{{mermaidId source}}} -->{{#if label}}|"{{label}}"|{{/if}} {{{mermaidId target}}}
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labels containing double quotes will break the Mermaid syntax. For example, a label like Say "Hello" would produce invalid Mermaid: |"Say "Hello""|. Consider creating a Handlebars helper to escape double quotes in labels (e.g., {{escapeQuotes label}} that replaces " with \"). This issue also affects node labels throughout the codebase (lines 27, 30 in this file, and in container.hbs and typed-node.hbs), but is particularly relevant here since quotes are being added.

Suggested change
{{{mermaidId source}}} -->{{#if label}}|"{{label}}"|{{/if}} {{{mermaidId target}}}
{{{mermaidId source}}} -->{{#if label}}|"{{escapeQuotes label}}"|{{/if}} {{{mermaidId target}}}

Copilot uses AI. Check for mistakes.
{{/each}}

{{!-- Dotted attachments (node -> interface) --}}
Expand Down
Loading