AssetBase Payer and Receiver Refactor#4521
Open
tomhealey-icma wants to merge 12 commits intofinos:masterfrom
Open
AssetBase Payer and Receiver Refactor#4521tomhealey-icma wants to merge 12 commits intofinos:masterfrom
tomhealey-icma wants to merge 12 commits intofinos:masterfrom
Conversation
✅ Deploy Preview for finos-cdm ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was
linked to
issues
Mar 30, 2026
Contributor
|
There is a test that checks any Rune code that is referenced in the documentation is kept in sync. 
|
Contributor
Author
|
Hugo - yes i've made the docs changes locally but haven't pushed to the pr yet because of the ingestion tests failing. |
Contributor
Author
|
All the changes have been submitted and the build is successful. The CVE error is unrelated to my changes. Request cdm maintainer review. |
tomhealey-icma
requested review from
CDM-ReleaseManagement-OT,
chrisisla and
lolabeis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses three issues and replaces PR 3666::
Define who pays / receives (Party1 / Party2) for a Tradeable Product's embedded payout #3590
Add product issuer, #3567
AssetType is not included in Product although it's part of CollateralCriteria and collateral EligibilityQuery. #3559
To address these issues the following changes are being made:
Add new PartyRole "Issuer"
Add productPartyRole CounterpartyRoleEnum (0..1) to TransferableProduct
Add to AssetBase:
party Party (0..1)
partyRole AssetPartyRole (0..1)
ancillaryPartyRole AssetAncillaryPartyRole (0..*)
assetType AssetTypeEnum (1..1)
Remove from AssetBase:
exchange
relatedExchange
Add new function input tests, bond-execution-with-bond-details.
Update flpm ingest functions.