Update test/example projects and workflows #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Target net10 for examples and tests, nuget packages remain netstandard2.0 * Update Newtonsoft.Json package version from 13.0.2 to 13.0.3 minimum
There was a problem hiding this comment.
Pull request overview
This PR aims to update test and example projects to target a newer .NET framework version and upgrade the Newtonsoft.Json package dependency. However, the PR targets .NET 10, which has not been released yet (as of January 2025).
Key changes attempted:
- Update target framework from net8.0 to net10.0 across all test and example projects
- Update Newtonsoft.Json package from version 13.0.2 to 13.0.3
- Update GitHub Actions workflow to use .NET 10.x SDK
- Add prerequisites documentation for .NET 10 SDK requirement
- Remove duplicate ProjectReference in AppDirectory.Tests
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Tests/Finos.Fdc3.Tests/Finos.Fdc3.Tests.csproj | Updates test project target framework to net10.0 |
| src/Tests/Finos.Fdc3.SystemTextJson.Tests/Finos.Fdc3.SystemTextJson.Tests.csproj | Updates test project target framework to net10.0 |
| src/Tests/Finos.Fdc3.NewtonsoftJson.Tests/Finos.Fdc3.NewtonsoftJson.Tests.csproj | Updates test project target framework to net10.0 and Newtonsoft.Json to 13.0.3 |
| src/Tests/Finos.Fdc3.AppDirectory.Tests/Finos.Fdc3.AppDirectory.Tests.csproj | Updates target framework to net10.0 and removes duplicate ProjectReference |
| src/Fdc3.NewtonsoftJson/Finos.Fdc3.NewtonsoftJson.csproj | Updates Newtonsoft.Json package dependency to 13.0.3 |
| src/Examples/WpfFdc3/WpfFdc3.csproj | Updates example project target framework to net10.0-windows |
| README.md | Adds prerequisites section documenting .NET 10 SDK requirement |
| .github/workflows/build.yml | Updates CI workflow to use .NET 10.x SDK |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 85.84% 85.84%
=======================================
Files 64 64
Lines 565 565
Branches 49 49
=======================================
Hits 485 485
Misses 61 61
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
psmulovics
approved these changes
Jan 20, 2026
Roaders
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE FINOS CORPORATE CONTRIBUTOR LICENSE AGREEMENT.
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.