Skip to content

Conversation

@RachelColman
Copy link
Contributor

This PR is to remove Camunda copyright statements on files that we had previously added unnecessarily to which do not need to be there.
These features do not contain any code copied over from the Camunda 7 CE version. The files do contain code from the bpmn.io repo (https://github.com/bpmn-io/bpmn-js-properties-panel) so we only need to ensure the LICENCE file references MIT.

@bryankenneally
Copy link
Contributor

@gliptak @pieter-schutte @finos/fluxnova-maintainers Would you mind reviewing when you have a chance please? Thanks

@@ -1,13 +1,3 @@
/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be removing any existing copyrights from camunda

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Very risky, and not sure what benefit we will get

Copy link
Contributor

@bryankenneally bryankenneally Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prajwol and I chatted about this today and think we can go ahead with removing the copyright statements because the files we copied from the bpm.io repo did not originate with Camunda, and should not be attributed by us to them. Our intention is to only remove copyright statements that were added by us in error. We won't be removing/changing statements on code that originated with Camunda.

Here's a detailed example to give better context:

Copy link
Collaborator

@HarishMalavade HarishMalavade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should retain existing copyrights as is

@RachelColman
Copy link
Contributor Author

We should retain existing copyrights as is

@HarishMalavade I will close off this PR as the only changes were to remove those copyright licences

@pieter-schutte
Copy link
Contributor

This PR is to remove Camunda copyright statements on files that we had previously added unnecessarily to which do not need to be there. These features do not contain any code copied over from the Camunda 7 CE version. The files do contain code from the bpmn.io repo (https://github.com/bpmn-io/bpmn-js-properties-panel) so we only need to ensure the LICENCE file references MIT.

Do we know how the statements got implemented in the 1st place?

@bryankenneally
Copy link
Contributor

bryankenneally commented Feb 6, 2026

This PR is to remove Camunda copyright statements on files that we had previously added unnecessarily to which do not need to be there. These features do not contain any code copied over from the Camunda 7 CE version. The files do contain code from the bpmn.io repo (https://github.com/bpmn-io/bpmn-js-properties-panel) so we only need to ensure the LICENCE file references MIT.

Do we know how the statements got implemented in the 1st place?

I've added some context here, Pieter: #53 (comment)

Copy link
Contributor

@prajwolbhandari1 prajwolbhandari1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change @RachelColman @bryankenneally

LGTM

Signed-off-by: Rachael Coleman <rachael.coleman@fmr.com>
@RachelColman RachelColman force-pushed the feature/update-copyright-statement branch from 69fd87b to 4fa1439 Compare February 11, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

5 participants