-
Notifications
You must be signed in to change notification settings - Fork 6
Remove copyright licences from job execution and form rebranding files #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Remove copyright licences from job execution and form rebranding files #53
Conversation
|
@gliptak @pieter-schutte @finos/fluxnova-maintainers Would you mind reviewing when you have a chance please? Thanks |
| @@ -1,13 +1,3 @@ | |||
| /** | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be removing any existing copyrights from camunda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Very risky, and not sure what benefit we will get
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prajwol and I chatted about this today and think we can go ahead with removing the copyright statements because the files we copied from the bpm.io repo did not originate with Camunda, and should not be attributed by us to them. Our intention is to only remove copyright statements that were added by us in error. We won't be removing/changing statements on code that originated with Camunda.
Here's a detailed example to give better context:
- JobExecutionProps.js file originally copied from bpmn-io repo (no copyright): https://github.com/bpmn-io/bpmn-js-properties-panel/blob/main/src/provider/camunda-platform/properties/JobExecutionProps.js
- PR where JobExecutionProps.js was copied over to Fluxnova Modeler repo (with a new copyright statement): https://github.com/finos/fluxnova-modeler/pull/37/changes#diff-0537b7c7489789075900758ec21310630d2632efcfffe1af9934850a34676befR3-R7
- Pieter asked why the copyright was added: Add retry time cycle group to element templates #37 (comment)
- New PR opened to remove copyright statement from JobExectionProps.js: https://github.com/finos/fluxnova-modeler/pull/53/changes#diff-0537b7c7489789075900758ec21310630d2632efcfffe1af9934850a34676bef
HarishMalavade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should retain existing copyrights as is
@HarishMalavade I will close off this PR as the only changes were to remove those copyright licences |
Do we know how the statements got implemented in the 1st place? |
I've added some context here, Pieter: #53 (comment) |
prajwolbhandari1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change @RachelColman @bryankenneally
LGTM
Signed-off-by: Rachael Coleman <rachael.coleman@fmr.com>
69fd87b to
4fa1439
Compare
This PR is to remove Camunda copyright statements on files that we had previously added unnecessarily to which do not need to be there.
These features do not contain any code copied over from the Camunda 7 CE version. The files do contain code from the bpmn.io repo (https://github.com/bpmn-io/bpmn-js-properties-panel) so we only need to ensure the LICENCE file references MIT.