Skip to content

Commit 3354838

Browse files
committed
chore: add tsc for just server and add to CI
Add type checking for the server to CI. Type Checking for the whole project would be good but the frontend has some typechecking rules which work fine for the build but tsc doesn't currently respect. Will fix in the future.
1 parent 8711aa5 commit 3354838

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,12 @@ jobs:
4545
- name: Install dependencies
4646
run: npm i
4747

48+
# for now only check the types of the server
49+
# tsconfig isn't quite set up right to respect what vite accepts
50+
# for the frontend code
51+
- name: Check Types (Server)
52+
run: npm run check-types:server
53+
4854
- name: Test
4955
id: test
5056
run: |

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
"build-lib": "./scripts/build-for-publish.sh",
1515
"restore-lib": "./scripts/undo-build.sh",
1616
"check-types": "tsc",
17+
"check-types:server": "tsc --project tsconfig.publish.json --noEmit",
1718
"test": "NODE_ENV=test ts-mocha './test/**/*.test.js' --exit",
1819
"test-coverage": "nyc npm run test",
1920
"test-coverage-ci": "nyc --reporter=lcovonly --reporter=text npm run test",

0 commit comments

Comments
 (0)