Merge branch 'G-Research:main' into auto-approve

Author: fabiovincenzi

.github/workflows/ci.yml

@@ -52,7 +52,7 @@ jobs:
         npm run test-coverage-ci --workspaces --if-present
 
     - name: Upload test coverage report
-      uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3 # v5.3.1
+      uses: codecov/codecov-action@0565863a31f2c772f9f0395002a31e3f06189574 # v5.4.0
       with:
         files: ./coverage/lcov.info
         token: ${{ secrets.CODECOV_TOKEN }}
@@ -71,13 +71,13 @@ jobs:
         path: build
 
     - name: Download the build folders
-      uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4
+      uses: actions/download-artifact@cc203385981b70ca67e1cc392babf9cc229d5806 # v4
       with:
         name: build
         path: build
 
     - name: Run cypress test
-      uses: cypress-io/github-action@18a6541367f4580a515371905f499a27a44e8dbe # v6.7.12
+      uses: cypress-io/github-action@108b8684ae52e735ff7891524cbffbcd4be5b19f # v6.7.16
       with: 
         start: npm start &
         wait-on: "http://localhost:3000"

.github/workflows/codeql.yml

@@ -60,7 +60,7 @@ jobs:
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@b56ba49b26e50535fa1e7f7db0f4f7b4bf65d80d # v3
+      uses: github/codeql-action/init@6bb031afdd8eb862ea3fc1848194185e076637e5 # v3
       with:
         languages: ${{ matrix.language }}
         # If you wish to specify custom queries, you can do so here or in a config file.
@@ -74,7 +74,7 @@ jobs:
     # Autobuild attempts to build any compiled languages (C/C++, C#, Go, Java, or Swift).
     # If this step fails, then you should remove it and run the build manually (see below)
     - name: Autobuild
-      uses: github/codeql-action/autobuild@b56ba49b26e50535fa1e7f7db0f4f7b4bf65d80d # v3
+      uses: github/codeql-action/autobuild@6bb031afdd8eb862ea3fc1848194185e076637e5 # v3
 
     # ℹ️ Command-line programs to run using the OS shell.
     # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -87,6 +87,6 @@ jobs:
     #     ./location_of_script_within_repo/buildscript.sh
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@b56ba49b26e50535fa1e7f7db0f4f7b4bf65d80d # v3
+      uses: github/codeql-action/analyze@6bb031afdd8eb862ea3fc1848194185e076637e5 # v3
       with:
         category: "/language:${{matrix.language}}"

.github/workflows/scorecard.yml

@@ -72,6 +72,6 @@ jobs:
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: "Upload to code-scanning"
-        uses: github/codeql-action/upload-sarif@b56ba49b26e50535fa1e7f7db0f4f7b4bf65d80d # v3.28.10
+        uses: github/codeql-action/upload-sarif@6bb031afdd8eb862ea3fc1848194185e076637e5 # v3.28.11
         with:
           sarif_file: results.sarif

cypress.config.js

@@ -1,7 +1,8 @@
-const { defineConfig } = require('cypress')
+const { defineConfig } = require('cypress');
 
 module.exports = defineConfig({
   e2e: {
-    baseUrl: process.env.CYPRESS_BASE_URL ||'http://localhost:3000',
+    baseUrl: process.env.CYPRESS_BASE_URL || 'http://localhost:3000',
+    chromeWebSecurity: false, // Required for OIDC testing
   },
-})
+});

cypress/e2e/login.cy.js

@@ -1,19 +1,33 @@
-describe("Display finos UI",()=>{
-  
-  beforeEach(() =>{
-    cy.visit('/login')
- })
- it('shoud find git proxy logo',() =>{
-  cy.get('[data-test="git-proxy-logo"]').should('exist')
-})
-  it('shoud find username',() =>{
-    cy.get('[data-test="username"]').should('exist')
-  })
+describe('Login page', () => {
+  beforeEach(() => {
+    cy.visit('/login');
+  });
 
-  it('shoud find passsword',() =>{
-    cy.get('[data-test="password"]').should('exist')
-  })
-  it('shoud find login button',() =>{
-    cy.get('[data-test="login"]').should('exist')
-  })
-})
+  it('should have git proxy logo', () => {
+    cy.get('[data-test="git-proxy-logo"]').should('exist');
+  });
+
+  it('should have username input', () => {
+    cy.get('[data-test="username"]').should('exist');
+  });
+
+  it('should have passsword input', () => {
+    cy.get('[data-test="password"]').should('exist');
+  });
+
+  it('should have login button', () => {
+    cy.get('[data-test="login"]').should('exist');
+  });
+
+  describe('OIDC login button', () => {
+    it('should exist', () => {
+      cy.get('[data-test="oidc-login"]').should('exist');
+    });
+
+    // Validates that OIDC is configured correctly
+    it('should redirect to /oidc', () => {
+      cy.get('[data-test="oidc-login"]').click();
+      cy.url().should('include', '/oidc');
+    });
+  });
+});