Skip to content

Conversation

jescalada
Copy link
Contributor

@jescalada jescalada commented Aug 18, 2025

Fixes #1155 and other issues with flaky tests.

Adds the validator library to check that emails have a valid format.

Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 802ba27
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/68a5a5312f66e2000860911c

@github-actions github-actions bot added the fix label Aug 18, 2025
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.80%. Comparing base (9679618) to head (802ba27).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
- Coverage   82.81%   82.80%   -0.01%     
==========================================
  Files          66       66              
  Lines        2787     2786       -1     
  Branches      335      334       -1     
==========================================
- Hits         2308     2307       -1     
  Misses        432      432              
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada linked an issue Aug 20, 2025 that may be closed by this pull request
@jescalada
Copy link
Contributor Author

Note: #1162 should be merged first as it has a fix for the proxyUrl test failure!

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves the situation and git-proxy's validation of emails. Approving on that basis.

However, I don't think it fully solves the flakiness in checkAuthorEmails, but will reduce the incidence rate by an order of magnitude.

To fully resolve you'd need to check if the string is an email (use the validator and flip the expect) or prevent it ever being one (e.g. by removing @ symbols or add something if one exists that guarantees it doesn't validate).

@jescalada jescalada merged commit d9d8b18 into finos:main Aug 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing checkAuthorEmails fuzz test Failing checkCommitMessages fuzz test
2 participants