-
Notifications
You must be signed in to change notification settings - Fork 141
fix: flaky fuzz test errors #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
- Coverage 82.81% 82.80% -0.01%
==========================================
Files 66 66
Lines 2787 2786 -1
Branches 335 334 -1
==========================================
- Hits 2308 2307 -1
Misses 432 432
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Juan Escalada <[email protected]>
Note: #1162 should be merged first as it has a fix for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This improves the situation and git-proxy's validation of emails. Approving on that basis.
However, I don't think it fully solves the flakiness in checkAuthorEmails
, but will reduce the incidence rate by an order of magnitude.
To fully resolve you'd need to check if the string is an email (use the validator and flip the expect) or prevent it ever being one (e.g. by removing @ symbols or add something if one exists that guarantees it doesn't validate).
Fixes #1155 and other issues with flaky tests.
Adds the
validator
library to check that emails have a valid format.