Skip to content

fix: convert remaining UI javascript to typescript#1329

Merged
jescalada merged 7 commits intofinos:mainfrom
andypols:fix-move-ui-js-to-ts
Dec 23, 2025
Merged

fix: convert remaining UI javascript to typescript#1329
jescalada merged 7 commits intofinos:mainfrom
andypols:fix-move-ui-js-to-ts

Conversation

@andypols
Copy link
Contributor

@andypols andypols commented Dec 15, 2025

Summary

This PR migrates a few remaining javascript files in the UI codebase to TypeScript and removes unused components.

Changes

TypeScript Conversions:

  • Converted Settings.jsx to Settings.tsx with proper type annotations
    • Added type annotations for state hooks (useState, useState)
    • Typed event handlers with return type : void
    • Typed event parameters (ChangeEvent)
    • Fixed invalid button color prop (color='default' removed)
  • Converted Danger.jsx to Danger.tsx with React.FC and proper props interface
  • Converted NotAuthorized.jsx and NotFound.jsx to .tsx (no-op renames as they were already TypeScript-compatible)

Cleanup - Removed Unused Components:

  • CustomInput.jsx
  • Table.jsx
  • Tasks.jsx
  • Unused Typography components: Info.jsx, Muted.jsx, Primary.jsx, Quote.jsx, Success.jsx, Warning.jsx

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 8b78ffb
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/694a4ac9677fc0000879a354

@github-actions github-actions bot added the fix label Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.65%. Comparing base (73b4831) to head (8b78ffb).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1329   +/-   ##
=======================================
  Coverage   80.65%   80.65%           
=======================================
  Files          65       65           
  Lines        4575     4575           
  Branches      774      774           
=======================================
  Hits         3690     3690           
  Misses        870      870           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andypols andypols requested a review from jescalada December 15, 2025 23:21
Copy link
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution @andypols 🚀

@jescalada jescalada enabled auto-merge December 23, 2025 07:55
@jescalada jescalada merged commit 102b837 into finos:main Dec 23, 2025
31 of 33 checks passed
@andypols andypols deleted the fix-move-ui-js-to-ts branch December 23, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants